[Multiple] Alt + Click Shows Multiple Icons

[TeDGamer]

Testmerges

#4379, #4182, #4378

Description of the bug

Similar to
#4369

But this one when checking the computers seems to be fixed

What's the difference with what should have happened?

Show only the icons for the items

How do we reproduce this bug?

1. Alt-click varadero's ship ( where the glowing slime is)

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Huffie56]

i can confirmed i had the same

[TeDGamer]

[TeDGamer]

[TeDGamer]

[Huffie56]

that's old not sure where it is now... reproduction it need

[Huffie56]

https://discord.com/channels/150315577943130112/964684928161808384/1191453491282051072
last report of it.

[SabreML]

I can't remember the exact details since it's been about 2 years since I last worked on it, but as far as I remember this is caused by a combination of the atom's icon_state being null (or being something that isn't in the .dmi file), and the .dmi file not having a default state set.

---

For example the two 'remains' ones above were likely caused by the xeno being gibbed:

cmss13/code/modules/mob/living/carbon/xenomorph/death.dm

Lines 137 to 140 in b1e7b70

	/mob/living/carbon/xenomorph/gib(datum/cause_data/cause = create_cause_data("gibbing", src))
	var/obj/effect/decal/remains/xeno/remains = new(get_turf(src))
	remains.icon = icon
	remains.pixel_x = pixel_x //For 2x2.

cmss13/code/game/objects/effects/decals/remains.dm

Lines 10 to 15 in b1e7b70

	/obj/effect/decal/remains/xeno
	name = "remains"
	desc = "They look like the remains of some horrible creature. They are not pleasant to look at..."
	gender = PLURAL
	icon = 'icons/effects/blood.dmi'
	icon_state = "remainsxeno"

death.dm L139 sets the remains effect's icon to the same as the dead xeno's, but since its icon_state of "remainsxeno" isn't a state in the xeno dmi, and there isn't a fallback 'default' state in there either, it just displays the whole file.