Hive Status Null Error

[TeDGamer]

Testmerges

#4379, #4182, #4378

Description of the bug

Just happened in this round. Attempting to access hive status didn't seem to work.

Was working earlier with second queen but then it stopped.

What's the difference with what should have happened?

Show regular hive status

How do we reproduce this bug?

Not sure how to replicate

1. Click hive status

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[TeDGamer]

[private-tristan]

typically happens when there's lots of xenos (starts breaking around 35-40+ or so?
seems to happen with pylons active.

[SabreML]

I get this pretty often too.
It looks like the error is coming from line 31 of HiveStatus.js, where the nicknumber isn't an entry in xeno_info. Although I'm not sure what could be causing a someone to be in xeno_keys but not xeno_info, considering both loop through totalXenos in the same way.

cmss13/tgui/packages/tgui/interfaces/HiveStatus.js

Lines 27 to 41 in 609dd8d

	xeno_keys.map((key, i) => {
	const nicknumber = key.nicknumber.toString();
	let entry = {
	nicknumber: nicknumber,
	name: xeno_info[nicknumber].name,
	strain: xeno_info[nicknumber].strain,
	location: xeno_vitals[nicknumber].area,
	health: xeno_vitals[nicknumber].health,
	ref: xeno_info[nicknumber].ref,
	is_ssd: xeno_vitals[nicknumber].is_ssd,
	is_leader: key.is_leader,
	is_queen: key.is_queen,
	};
	xeno_entries.push(entry);
	});

[SabreML]

Should have been fixed by #5249. @Huffie56

[Huffie56]

Should have been fixed by #5249. @Huffie56

yep thanks PR wasn't link to this issue.