Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can skip the larva queue #4498

Closed
2 of 3 tasks
ondrej008 opened this issue Sep 24, 2023 · 2 comments · Fixed by #4502
Closed
2 of 3 tasks

You can skip the larva queue #4498

ondrej008 opened this issue Sep 24, 2023 · 2 comments · Fixed by #4502
Labels
Bug Admin events aren't bugs

Comments

@ondrej008
Copy link
Contributor

Testmerges

#4391, #4463, #4427

Description of the bug

While you are a ghost, you can press the join as larva button, and if you are fast enough, join as a buried larva even though you're not the first in the queue.

image
image

What's the difference with what should have happened?

You should not be able to perform a Quick Time Event in order to bypass the larva queue.

How do we reproduce this bug?

  1. Have a couple players in the larva queue.
  2. Give the hive a larva.
  3. Have the players start spamming the join as larva button and then immediately hit buried larva.
  4. Congratulations, you've now bypassed the larva queue.

Issue Bingo
@ondrej008 ondrej008 added the Bug Admin events aren't bugs label Sep 24, 2023
@Drulikar
Copy link
Contributor

This is a known possibility and has always been the case even before larva queue. It's very specific timing though and requires you to know the tick when a larva converts or is added to pool.

@Drulikar
Copy link
Contributor

Though a solution that comes to mind is to disable join as xeno for buried larva while a queue exists.

@Drulikar Drulikar mentioned this issue Sep 25, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2023
@Drulikar
Disable join as xeno buried spawns when there is a queue (#4502)
1bd5639 
# About the pull request

This PR changes the logic of the Join as Xeno button to only offer
joining as a buried larva if the last call of get_alien_candidates had
no candidates. This means almost never will join as xeno offer buried
spawns unless the queue was empty. Instead, hive cores ticking
(basically they are the larva queue) and larva pops will be the avenue
to join as a buried larva.

Also removes the ghost popup on hive surge if there is a queue. The
messages ultimately wouldn't allow buried spawns regardless, but no
point notifying ghosts if its not possible.

# Explain why it's good for the game

Fixes #4498 and as I mentioned there, this was a possibility even before
the larva queue system (when it would just randomly give larva to a
ghost that's eligible rather than in time of death order). It did
require you to know exactly when a stored larva is added to the hive and
to be attempting join as xeno between hive core's processing windows,
but since this action is hotkey-able, its pretty easy to just spam to
force yourself into that window.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>

# Changelog
:cl: Drathek
fix: Join as xeno no longer offers buried larva spawns if there are
larva queue candidates
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable join as xeno buried spawns when there is a queue Drulikar/cmss13
2 participants
@ondrej008 @Drulikar