Blood on a weed blocks knife hits sometimes.

[gitbirb]

Testmerges

#4505: 'Get Flat Icon Fixes' by Drulikar at commit 6021245 #4391: 'Hijack objectives' by morrowwolf at commit c34cb00 #4534: '"Fixes" missing window frame icon states' by morrowwolf at commit 7cf004c #4535: 'Floodlight rework' by morrowwolf at commit 311b510 #4502: 'Disable join as xeno buried spawns when there is a queue' by Drulikar at commit 1dc175c #4549: 'Helmet Optics Update' by morrowwolf at commit a7820b1

---

Description of the bug

If theres blood on resin, the blood decal can block clicks (such as knife melee) from hitting the resin.

What's the difference with what should have happened?

Blood should not eat clicks. Especially since blood pools can cover like... 2/3rds, if not 3/4ths of a resin weed sprite.

---

How do we reproduce this bug?

1. Try to click the weed tiles where the blood is (spriteclick the blood pools)
2. The blood blocks the melee clicks
3. Try to click the weed tile (spriteclick the weed, avoiding the blood pools)
4. You destroy the weed.
   ...

///
(edit 8/31/2024)

It might just be because of weird interactions with cooldowns?

(defining: melee cooldown, vs click cooldown)

• Click cooldown: Once you click, you have a cooldown before you can click again. The cooldown is always applied once you click.
• Melee cooldown: Once you melee strike, you have a cooldown before you can melee strike again. The cooldown is only applied once you hit a melee strike.

Normally melee cooldown is all that matters against weeds, and click cooldown is probably not a factor. However, I think the reason for this inconsistency, is that click cooldown DOES matter, when hitting blood decals ontop of weeds?

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[gitbirb]

im gonna close this and test it more

[gitbirb]

Couldn't reproduce, maybe misremembered how it works, or maybe it was a latency issue

[morrowwolf]

I've similarly had issues with it recently and I'm not sure why it seems to work sometimes. The code seems to function correctly and it's in there to pass along the attack 🤷

[gitbirb]

Alright so, i DO think it's a real issue, since i've experienced it so much. But I have 0 clue why it works sometimes, why it doesn't work sometimes.

It's super annoying and time consuming, when you want to push and clicking weeds are blocked by blood decals

it may be a server-only issue. As if the code maybe functions differently online and offline?
It may have something to do with specific blood decals too. So not all decals would do it?
// I do think it has to do with specific blood decals - since on rounds when this happen, a few types of blood 100000% block clicks, and others don't. I haven't kept track though

it may be different between acid blood and red blood - or maybe need both?
It may have to do with the time a round has gone on for?
It may have to do with server lag?
It may have to do with total number of decals?

i dunno, maybe the only real way to thoroughly test it would be adding feedback to missed melee strikes

[ItsVyzo]

Duplicate #1151

[gitbirb]

Duplicate #1151

Different issues.

That issue is about how mops hit the weed instead of the floor.
This issue is about how a knife does not hit the weed, because of the blood decal covering the weed.

I should probably rewrite the post to clarify it though...