Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ballistic goggles no longer show on patrol caps #4602

Closed
3 tasks done
Wintermote opened this issue Oct 8, 2023 · 3 comments · Fixed by #4613
Closed
3 tasks done

Ballistic goggles no longer show on patrol caps #4602

Wintermote opened this issue Oct 8, 2023 · 3 comments · Fixed by #4613
Labels
Bug Admin events aren't bugs

Comments

@Wintermote
Copy link

Wintermote commented Oct 8, 2023 •
edited
Loading

Testmerges

#4575

Description of the bug

Someone changed the ballistic goggles sprites; they no longer show on patrol caps - a functionality they used to have.
There is also a function to flip down the goggles so they show on your face, but this function doesn't work.

What's the difference with what should have happened?

Expected:
All the old ballistic goggle sprites should have been replaced by the new ballistic goggle sprites
Flipping the goggles down will display the goggle sprite on your face

What has happened:
Some of the old ballistic goggle sprites were not replaced and are now missing
Flipping the goggles down does not display the goggle sprite on your face

How do we reproduce this bug?

  1. Wear patrol cap
  2. Wear ballistic goggles in the cap
  3. Press the "flip goggles down" UI button

Issue Bingo
@Wintermote Wintermote added the Bug Admin events aren't bugs label Oct 8, 2023
@fira
Copy link
Member

fira commented Oct 8, 2023

Probably linked to #4557

@irRegularGuy646
Copy link
Contributor

i haven't touched the old sprites, and i apparently didn't name the new goggle's on helmet states correctly.

@irRegularGuy646 irRegularGuy646 mentioned this issue Oct 9, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2023
@irRegularGuy646
Fixes previous goggle pr helmet sprites (#4613)
0c23c26 
# About the pull request

fixes my goggle's helmet sprite

# Explain why it's good for the game

fixes #4602 and #4615

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/71989367/d6c17c80-d9e1-4ae5-9f73-24d7b95d56a9)

![image](https://github.com/cmss13-devs/cmss13/assets/71989367/90f9b7d7-e896-4b81-9a36-d82ad070f380)

![image](https://github.com/cmss13-devs/cmss13/assets/71989367/f1aacaf3-300d-46ce-9709-31059193ae29)

![image](https://github.com/cmss13-devs/cmss13/assets/71989367/c1594cbe-19b0-4ca5-af70-0617c187bdec)


</details>


# Changelog
:cl:
fix: fixed new goggle's on helmet sprite
/:cl:
@Wintermote
Copy link
Author

This issue is still not actually fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes previous goggle pr helmet sprites irRegularGuy646/cmss13
3 participants
@fira @Wintermote @irRegularGuy646