Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP Armour Colour #4664

Closed
3 tasks done
dead-man-walking opened this issue Oct 13, 2023 · 6 comments
Closed
3 tasks done

MP Armour Colour #4664

dead-man-walking opened this issue Oct 13, 2023 · 6 comments
Labels
Confirmed Bug We have the same at home! Consistency Issue Who needs consistency? Sprites Remove the soul from the game.

Comments

@dead-man-walking
Copy link

Testmerges

#4575 #4437 #4539 #4337 #4649

Description of the bug

The MP's armour on the characters sprite does not match the map armour colour despite this fact the armour in the equipment slot shows the proper armour colour dependent on the map.

What's the difference with what should have happened?

the armour should be the proper colour on the characters sprite dependent on the map on both the sprite and the equip slot.

How do we reproduce this bug?

  1. Wear MP armour
  2. Look at the sprite

Issue Bingo

@dead-man-walking dead-man-walking added the Bug Admin events aren't bugs label Oct 13, 2023
@Huffie56 Huffie56 added Consistency Issue Who needs consistency? and removed Bug Admin events aren't bugs labels Nov 29, 2023
@Huffie56
Copy link
Contributor

@dead-man-walking
On what maps this is happening?
is MP the only role where this is happening?

and last ... is it still happening?

@dead-man-walking
Copy link
Author

@Huffie56
The maps that it happens on depends on what the maps Armour colour is so the MP armour colour is forest green like LV-624 its fine but on the maps where it is Urban(?) cyan like prison station or chances clam, Desert tan like dam or big red but i am not sure for snow maps but on these maps the on character sprite for the armour is incorrect almost always showing it as forest green no matter the map.
as for any other roles that have this issue its only really effecting the MP and MP Warden.
and yes it is still happening just checked today and the on character sprite for the mp armour is still wrong.

@Huffie56 Huffie56 added the Confirmed Bug We have the same at home! label Dec 2, 2023
@ItsVyzo ItsVyzo added Sprites Remove the soul from the game. and removed Sprites Remove the soul from the game. labels Dec 12, 2023
@Huffie56 Huffie56 added the Sprites Remove the soul from the game. label Dec 14, 2023
@dead-man-walking
Copy link
Author

seems this issue has been pushed down and i don't suspect it will be fixed any time soon.

@Huffie56
Copy link
Contributor

seems this issue has been pushed down and i don't suspect it will be fixed any time soon.

didn't got push down it's just that more issues got reported.
if you want you can post the issue on spriter channel and ask someone to fix it.

@dead-man-walking
Copy link
Author

so it seems one of the recent PR's seemed to have fixed the mp armour ( i don't remember what one exactly but i think it was the one that added the urban armour colour ) but as of current it seem what ever PR was ceased

@ItsVyzo
Copy link
Contributor

ItsVyzo commented Aug 31, 2024

this seems to be fixed now

@ItsVyzo ItsVyzo closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug We have the same at home! Consistency Issue Who needs consistency? Sprites Remove the soul from the game.
Projects
None yet
Development

No branches or pull requests

3 participants