-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprite damage doesn't resolve after healing #4764
Comments
shared issue with this older issue i assume... |
I am not able to reproduce this issue as described. Tried punching head. Tried punching eyes. Tried shooting with a m41a in various body parts. Splint overlay is removed when splints are removed. Damage overlay is removed when fully healed with meds. |
last time i was able to reproduce was unable to remove the blood overlay sprite near the eyes...(damage to the eyes i think?) |
I know this one and can confirm that it is a thing. Will fix. |
# About the pull request Yet another disastrous consequence of that "research warcrimes" PR. For whatever reason, it removed a line that actually was doing something important. If we have been processing the limb (otherwise `need_process()` should not be called at all) and after going through all the checks decided to cease processing it (which only happens when all damage is gone), we do need to update wounds one final time first to remove all the overlays from wounds/bandages that have healed but have not been removed by limb's not-every-tick update in regular `process()`. # Explain why it's good for the game Fixes #4764. # Changelog :cl: fix: Fully healed limbs should now properly remove the overlays for their wounds and bandages. /:cl:
Testmerges
#4475, #4627, #4623, #4699, #4723, #4696, #4558
Round ID
No response
Description of the bug
If you injure yourself or become injured, a blood decal overlay will be applied to your sprite.
If you then heal fully, this blood will remain and never go away.
It cannot be washed off, or removed with spray bottles.
Additionally, this is also an issue I've noticed with splints not being removed from your sprite after you've removed them mechanically/been treated and the cause is probably similar.
This issue is older than the current testmerges.
What's the difference with what should have happened?
What's expected (and used to be normal until recently):
After taking damage and having blood decals applied to your sprite, if you heal the decals will disappear.
(I don't know if washing also did but it was tied to your health so I don't think so)
What is happening now:
After taking damage and healing, blood decals are not being removed from the sprite
How do we reproduce this bug?
Issue Bingo
The text was updated successfully, but these errors were encountered: