Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite damage doesn't resolve after healing #4764

Closed
3 tasks done
Wintermote opened this issue Oct 22, 2023 · 5 comments · Fixed by #5787
Closed
3 tasks done

Sprite damage doesn't resolve after healing #4764

Wintermote opened this issue Oct 22, 2023 · 5 comments · Fixed by #5787
Assignees
Labels
Confirmed Bug We have the same at home! Sprites Remove the soul from the game.

Comments

@Wintermote
Copy link

Testmerges

#4475, #4627, #4623, #4699, #4723, #4696, #4558

Round ID

No response

Description of the bug

If you injure yourself or become injured, a blood decal overlay will be applied to your sprite.
If you then heal fully, this blood will remain and never go away.

It cannot be washed off, or removed with spray bottles.

Additionally, this is also an issue I've noticed with splints not being removed from your sprite after you've removed them mechanically/been treated and the cause is probably similar.

This issue is older than the current testmerges.

What's the difference with what should have happened?

What's expected (and used to be normal until recently):
After taking damage and having blood decals applied to your sprite, if you heal the decals will disappear.
(I don't know if washing also did but it was tied to your health so I don't think so)

What is happening now:
After taking damage and healing, blood decals are not being removed from the sprite

How do we reproduce this bug?

  1. Punch yourself
  2. Observe blood decals applied to sprite
  3. Use tricord or other medicine to heal
  4. Observe blood decals are still applied to sprite
  5. Use showers, go in water, use spray bottle, etc. to remove blood
  6. Observe blood decals are still applied to sprite

Issue Bingo

@Wintermote Wintermote added the Bug Admin events aren't bugs label Oct 22, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Dec 9, 2023

shared issue with this older issue i assume...
#4382

@Huffie56
Copy link
Contributor

i could reproduce part of it with some damage overlay maybe linked to the eyes
image
manage to remove it with aheal only...

@Huffie56 Huffie56 added Confirmed Bug We have the same at home! Sprites Remove the soul from the game. and removed Bug Admin events aren't bugs labels Dec 10, 2023
@Drulikar
Copy link
Contributor

I am not able to reproduce this issue as described. Tried punching head. Tried punching eyes. Tried shooting with a m41a in various body parts.

Splint overlay is removed when splints are removed.

Damage overlay is removed when fully healed with meds.

@Huffie56 Huffie56 added Needs Reproducing We're not even sure if you know how to do it and removed Confirmed Bug We have the same at home! labels Jan 26, 2024
@Huffie56
Copy link
Contributor

last time i was able to reproduce was unable to remove the blood overlay sprite near the eyes...(damage to the eyes i think?)
the only way to fix it was aheal...
will check if i can reproduce it myself again... and would put a way of reproduce it....

@Segrain
Copy link
Contributor

Segrain commented Feb 2, 2024

I know this one and can confirm that it is a thing. Will fix.

@Segrain Segrain self-assigned this Feb 2, 2024
@Segrain Segrain added Confirmed Bug We have the same at home! and removed Needs Reproducing We're not even sure if you know how to do it labels Feb 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 23, 2024
# About the pull request

Yet another disastrous consequence of that "research warcrimes" PR. For
whatever reason, it removed a line that actually was doing something
important. If we have been processing the limb (otherwise
`need_process()` should not be called at all) and after going through
all the checks decided to cease processing it (which only happens when
all damage is gone), we do need to update wounds one final time first to
remove all the overlays from wounds/bandages that have healed but have
not been removed by limb's not-every-tick update in regular `process()`.

# Explain why it's good for the game

Fixes #4764.


# Changelog

:cl:
fix: Fully healed limbs should now properly remove the overlays for
their wounds and bandages.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug We have the same at home! Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants