Some bullets can sometimes insta kill (maybe just IFF ones)

[CrazySquirrel7O]

Testmerges

#4475, #4627, #4623, #4699, #4723, #4696, #4558

Round ID

19177

Description of the bug

Playing as xeno, had more than 70% health (at least) and got hit by one single smart gunner bullet, died and got gibbed instantly, ahelped it and biolock after some log searching told me that indeed I had only been hit once and to bug report it.

Here is a screenshot of the transition from alive do dead, at the top you can see I was alive (was going to use acid spray), then I could see dead chat.
https://gyazo.com/30fd896ecf4d302e28c815cfbbda3f43

What's the difference with what should have happened?

I should have just taken about 20-25 damage maximum and kept on, instead I died.

How do we reproduce this bug?

1.Play xeno
2.Get hit by some bullet (If biolock is right probably needs to be IFF)
3.Pray the bug repeats
4.If you die even if you had a lot of health it worked
5.Else repeat

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[CrazySquirrel7O]

I don't use Github very much so if you need to ask me something just @ me on the CM discord as Squirrel/ Ava B/ AV-B

[ihatethisengine]

What caste and strain were you playing?

[Biolock1]

They were playing a praetorian. I just had another player ahelp about the same incident happening with them. They were shot by an M4RA one time, and the M4RA had a smartscope.

[ihatethisengine]

Well, this is really weird. I couldn't reproduce it no matter what I tried and I didn't find anything in my code that could affect damage. And not like other TMed PRs could cause the issue either. The fact the bug is reoccurring is very concerning. I'll be looking into it but please tell me if it happens again. Kinda weird it didn't happen yesterday or the day before, but maybe people just assumed nothing wrong happened.

[CrazySquirrel7O]

It was a praetorian with the warden strain.

[ihatethisengine]

#4645
Might be the reason theoretically? It does mess with bullet traits and time seems to match and there were other weird occurrences today that didn't involve IFF.

I recently observed an incident of a larva tanking 30 bullets from a m41a without dying, I'd be concerned if this is occuring to other regular xenos
it was in ETA, a larva ran out of the hive to the front and got shot, it fell into crit but it was shot a subsequent 30 times before it healed and escaped
it was earlier today

[Biolock1]

It's happening frequently enough that we should be able to narrow down whether it's this IFF PR by simply isolating it, no?

[ihatethisengine]

Well if it happened only twice and both instances were today and there is no clear way to reproduce the bug, then not really. I do suspect #4645 because it touches bullet traits (such as IFF) in a way it's not easy to see the consequences, while the IFF PR doesn't really touch anything related to bullets (except pure damage, but that's a simple number change). I'll do more tests to try to find the issue.

[ihatethisengine]

Although fira says it wasn't live when the issue was created, so probably not.

[Lagomorphica]

happened to me just last round (19186) on LV-624

crusher full HP + shield got hit by a M4RA round instantly dead + gibbed
also killed the queen

[Biolock1]

Ah yes, that's the other commonality between them. It always seems to gib the body.

[Wintermote]

During the first round of the IFF PR on new varedaro, I accidentally PB'd a marine with an M4RA and he instantly died. I don't know how much health he had but the medic treating him said he had 200-something damage. I thought it was really weird because it was just one hit and BOOM straight up completely dead instantly. Not even the normal bit of lag time where you run around for 30 seconds in crit but the game doesn't recognize it yet. He was just instantly dead.

Because I didn't know his health before I just assumed he'd already taken damage but since this report is here I'll add the anecdote that there might be something to it.

[ihatethisengine]

Both bugs should be fixed in the PR. If the PR gets rejected I might port PB fix in a different PR.

[Huffie56]

hello is this fixed @ihatethisengine ?

[Huffie56]