Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you cant add your comms to the tcomm tower #4766

Closed
3 tasks done
QuickLode opened this issue Oct 22, 2023 · 1 comment · Fixed by #5833
Closed
3 tasks done

you cant add your comms to the tcomm tower #4766

QuickLode opened this issue Oct 22, 2023 · 1 comment · Fixed by #5833
Labels
Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it

Comments

@QuickLode
Copy link
Contributor

Testmerges

The following pull requests are currently test merged: #4475: 'Adds drawing to tacmaps' by Cthulhu80 at commit 57fce31 #4627: 'M39 being able to use vertical grip again [BUFF]' by irakligabunia at commit 6d4bb12 #4623: 'Reimplements halloween pumpkin helmets event' by fira at commit d628959 #4699: 'Hijack Objectives & Self Destruct ' by Zonespace27 at commit d80f3b2 #4723: 'Alternative IFF' by ihatethisengine at commit 091b8cb #4696: 'Fixes Smartfridge deletions + Turing/Smartfridge networking issue' by fira at commit 871be8c #4558: 'TGUI / Bugfixes / Improvements: Security Cleanup' by Crowbar764 at commit 4b29dca

Round ID

19180

Description of the bug

in #4479 someone said you are supposed to multitool to get comms

Well you can't multitool to get comms - this was tested with organic FORECON by CO, Synth and engineer. None work.

Also tested this in a separate round where TWE was spawned - TWE could not add their freq to the tcomms terminals either.

What's the difference with what should have happened?

By interacting with a powered tcomms using your multitool, you should be able to add any frequencies that you currently have onto the tcomms terminal.

Unfortunately, when you press "add frequencies" it'll tell you that you added them. But in reality you still can't use your freq.

How do we reproduce this bug?

  1. Be FORECON Survivors
  2. Go shipside, SOF freq works
  3. Go to planet, use other freqs just fine because tcomms repaired
  4. Add your freq via multitool.
  5. try using SOF freq, only SOF freq doesnt work because it didnt update
    ...

Issue Bingo

@QuickLode QuickLode added the Bug Admin events aren't bugs label Oct 22, 2023
@Huffie56
Copy link
Contributor

aren't forecon freq on the com from the start?
you may just have wiped it from the com by interacting with the multi-tool?

@Huffie56 Huffie56 added the Needs Reproducing We're not even sure if you know how to do it label Nov 29, 2023
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
# About the pull request

I pondered for a bit whether FORECON fixing radiotowers should allow
them to simply use Almayer's frequences (which might require giving them
appropriate headsets or not), but decided to keep it out of scope for
now. Tell me if we actually want it to be a thing.

Also, we apparently have `FACTION_USCM` and `FACTION_MARINE` both
\#defined as same thing. Before it would get out of hand, I am axing it
in favour of more commonly used one of the two.

P.S. I am not sure what is the matter with wiping frequences. Even after
fixing the spelling in the `switch`, it does now remove them from the
list, but that does not seem to prevent them from working. I am calling
that out of scope for now too and leave investigating it for another
day.

# Explain why it's good for the game

Fixes #4766, fixes #5797.

# Changelog

:cl:
fix: FORECON and RMC now can add their frequences to groundside
radiotowers.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants