Emergency shutters dont work

[Releasethesea]

Testmerges

#4475, #4812, #4793, #4866, #4863, #4872

Round ID

19438

Description of the bug

Emegency shutters are opening in the wrong areas all over the ship

What's the difference with what should have happened?

they should only open where they are at, not outside of the area, heres my crude drawings showing what happens, this occurs are multiple locations through the ship which it shouldnt be doing

How do we reproduce this bug?

1. toggle the fire alarm
   2.look outside of the area
   3.see its not properly aligned with the area/where its ment to be
   ...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Huffie56]

after testing this is a bug and not a simple mapping issue.

[ghost]

yeah, this is fucked.

[Huffie56]

so yes commenting out looking out work for some situation but on other we need code to look out for adjacent shutter to close.

let's imagine an extreme example where red is "area A"(red)and is surrounded by other areas with their shutter at their access
@Cthulhu80

[Huffie56]

you need in some way to only restrict it to only check adjacent area that have floor on both area.
not sure if that phrase make sense....

[Huffie56]

remapping area could also be a solution in most case...?

[ghost]

wat

[ghost]

I mean, idk man, whatever ya want me to do. I ain't no mapper though. I think you are, right? Might be a task for you then.

[Huffie56]

I mean, idk man, whatever ya want me to do. I ain't no mapper though. I think you are, right? Might be a task for you then.

let's just wait to see what a maintainer say about your solution.

[ghost]

Said this on discord but, maybe instead we can instead have it so that all connected fire shutters to any adjacent shutter close as well. That way it doesn't look funky and closes all the nearby room shutters.