Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squads sometimes fail to delete Marines references, bricking OW Console #4908

Open
3 tasks done
fira opened this issue Nov 12, 2023 · 0 comments
Open
3 tasks done

Squads sometimes fail to delete Marines references, bricking OW Console #4908

fira opened this issue Nov 12, 2023 · 0 comments
Labels
Bug Admin events aren't bugs

Comments

@fira
Copy link
Member

fira commented Nov 12, 2023

Testmerges

#4475, #4812, #4793, #4866, #4879, #4889

Round ID

19491, more

Description of the bug

Observed two times. In both cases the SL for the squad was deleted.
This causes the OW console to crash due to trying to get dist between marines and SL while it is in nullspace.

First case the console only briefly crashed before recovering.
During Round 19491 however the references to the SL (Spec assigned SL) were never cleared and it remained broken.

What's the difference with what should have happened?

The squad datum should automatically clear references to deleted squad members using the signal hooked in put_marine_in_squad

How do we reproduce this bug?

Unknown

This could be fixed by fixing the Z check in OW console, but arguably fixing the root cause would be much better

Issue Bingo

@fira fira added the Bug Admin events aren't bugs label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

No branches or pull requests

1 participant