Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensor towers can be deleted somehow (by explosives(?)) #4958

Closed
2 of 3 tasks
gitbirb opened this issue Nov 19, 2023 · 0 comments · Fixed by #4984
Closed
2 of 3 tasks

Sensor towers can be deleted somehow (by explosives(?)) #4958

gitbirb opened this issue Nov 19, 2023 · 0 comments · Fixed by #4984
Labels
Bug Admin events aren't bugs

Comments

@gitbirb
Copy link

gitbirb commented Nov 19, 2023 •
edited
Loading

Testmerges

#4793: 'ports the tg profiler subsystem' by harryob at commit 4b06b80 #4866: 'Radio TGUI backend Tidy-up & Adds Listening Devices' by realforest2001 at commit 3bd17b5 #4915: 'Hotfixes accidental early update_canmove removal' by fira at commit 9852f1f #4934: 'Allow playing uploaded sounds through the music player w/ Webroot' by fira at commit 8a5003a

Round ID

The round before 19585, not sure the exact round id

Description of the bug

There is supposed to be a sensor tower here
image

I'm not sure how it was destroyed, but someone said it can be destroyed by explosives in discord.

What's the difference with what should have happened?

Sensor towers have a broken state and are repairable (like comms), so they aren't supposed to get completely deleted by explosions.

How do we reproduce this bug?

  1. Have a sensor tower
  2. Explode it(?)
  3. Instead of sensor tower switching to the broken state, it's just gone?
    ...

Issue Bingo
@gitbirb gitbirb added the Bug Admin events aren't bugs label Nov 19, 2023
@gitbirb gitbirb changed the title Sensor towers can be destroyed (by explosives(?)) Sensor towers can be deleted (by explosives(?)) Nov 19, 2023
@gitbirb gitbirb changed the title Sensor towers can be deleted (by explosives(?)) Sensor towers can be deleted somehow (by explosives(?)) Nov 19, 2023
@Birdtalon Birdtalon mentioned this issue Nov 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 22, 2023
@Birdtalon
Adds explosion handling to experimental sensor tower (#4984)
81f55a3 
# About the pull request

Fixes #4958 

Adds explosion handling to sensor tower.

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
add: Explosion handling logic to experimental sensor tower.
fix: Explosions no longer delete experimental sensor tower.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds explosion handling to experimental sensor tower Birdtalon/cmss13
1 participant
@gitbirb