Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchoring bug for "/obj/item/stack/flag" #5145

Closed
3 tasks done
Nanu308 opened this issue Dec 6, 2023 · 0 comments · Fixed by #5409
Closed
3 tasks done

Anchoring bug for "/obj/item/stack/flag" #5145

Nanu308 opened this issue Dec 6, 2023 · 0 comments · Fixed by #5409
Labels
Bug Admin events aren't bugs

Comments

@Nanu308
Copy link
Member

Nanu308 commented Dec 6, 2023

Testmerges

#4986,#4939, #5054, #4842, #5067, #5018, #5127, #5134

Round ID

19833

Description of the bug

Placing flags from a stack of flags will lead to the remaining flags in a stack to turn anchored when you drop or throw the stack of flags.

What's the difference with what should have happened?

The stack of flags should not anchor themselves.

How do we reproduce this bug?

  1. Place flags into the ground from /obj/item/stack/flag/
  2. Keep a few flags in hand.
  3. Drop or throw away remaining flags.
  4. See how the flags will remain anchored and you cannot unanchor them outside of VV, with exception of the place flags.

bilde
bilde
bilde

...

Issue Bingo
@Nanu308 Nanu308 added the Bug Admin events aren't bugs label Dec 6, 2023
@Nanu308 Nanu308 mentioned this issue Dec 6, 2023
Closed
@Vicacrov Vicacrov mentioned this issue Jan 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 11, 2024
@Vicacrov @Nanu308
Fixes stack of flags anchoring after placing one down (#5409)
027fbaa 
# About the pull request

Currently, when you put down a flag, the stack of flags in your hand
becomes anchored instead of the placed down flag. Fixes #5145

# Explain why it's good for the game

The actual flag gets anchored, not the stack of flags in your hands.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/49321394/fb9092a5-9c2e-4d86-a591-e9f793a62a2e

</details>


# Changelog

:cl:
fix: Placing flags now anchors the actual flag, not the stack of flags
in your hand.
/:cl:

Co-authored-by: Nanu308 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes stack of flags anchoring after placing one down Vicacrov/cmss13
1 participant
@Nanu308