Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wall inside of door on Kutjevo #5238

Closed
3 tasks done
sargashC opened this issue Dec 17, 2023 · 3 comments · Fixed by #5239
Closed
3 tasks done

Wall inside of door on Kutjevo #5238

sargashC opened this issue Dec 17, 2023 · 3 comments · Fixed by #5239
Assignees
@Huffie56
Labels
Confirmed Bug We have the same at home! Mapping did you remember to save in tgm format?

Comments

@sargashC
Copy link

Testmerges

#4842, 5007, 4477 5204 5202 5219 5235

Round ID

19996

Description of the bug

On east side of of medical stormlocks, a door exists that just has a wall in it. Leading south into construction.
image

What's the difference with what should have happened?

Either no wall, or no door (I think it's a good door.)

How do we reproduce this bug?

1.Go to kutjevo
2.Go to the spot mentioned

Issue Bingo
@sargashC sargashC added the Bug Admin events aren't bugs label Dec 17, 2023
@Huffie56 Huffie56 added the Mapping did you remember to save in tgm format? label Dec 17, 2023
@Huffie56 Huffie56 self-assigned this Dec 17, 2023
@Huffie56 Huffie56 added the Needs Reproducing We're not even sure if you know how to do it label Dec 17, 2023
@Huffie56
Copy link
Contributor

i tested it and i think that's the spot couldn't find the door
was it on an event round?
image

@sargashC
Copy link
Author

sargashC commented Dec 17, 2023 •
edited
Loading

image
Its near
image
Not an event round, but might be an RNG map variant.

@Huffie56
Copy link
Contributor

thanks for the new image and yes it was a nightmare insert...
image

@Huffie56 Huffie56 added Confirmed Bug We have the same at home! and removed Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it labels Dec 17, 2023
@Huffie56 Huffie56 mentioned this issue Dec 17, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 18, 2023
@Huffie56
fix a nightmare insert that had a wall and a door on same tile (#5239)
7640a34 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

# About the pull request

fix a nightmare insert that had a wall and a door on same tile

fixes: #5238

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

fixing bug good

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding, and may discourage maintainers from reviewing or merging
your PR. This section is not strictly required for (non-controversial)
fix PRs or backend PRs. -->


# Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
label your changes in the changelog. Please note that maintainers freely
reserve the right to remove and add tags should they deem it
appropriate. You can attempt to finagle the system all you want, but
it's best to shoot for clear communication right off the bat. -->
<!-- If you add a name after the ':cl', that name will be used in the
changelog. You must add your CKEY after the CL if your GitHub name
doesn't match. Maintainers freely reserve the right to remove and add
tags should they deem it appropriate. -->

:cl:
fix: fix a nightmare insert that had a wall and a door on same tile.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! -->

Co-authored-by: Julien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Huffie56 Huffie56

Labels
Confirmed Bug We have the same at home! Mapping did you remember to save in tgm format?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix a nightmare insert that had a wall and a door on same tile Huffie56/cmss13
2 participants
@sargashC @Huffie56