Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buckled Info Tip Buckling A Little Too Much! #5344

Closed
3 tasks done
Superwelder opened this issue Dec 30, 2023 · 0 comments · Fixed by #5349
Closed
3 tasks done

Buckled Info Tip Buckling A Little Too Much! #5344

Superwelder opened this issue Dec 30, 2023 · 0 comments · Fixed by #5349
Labels
Bug Admin events aren't bugs

Comments

@Superwelder
Copy link

Superwelder commented Dec 30, 2023

Testmerges

#5298, #5246, #5113,#5285, #5153, #5007, #5304, #5294, #5122, #5086, #5337

Round ID

Issue occurs across every round for the last few weeks or so.

Description of the bug

The newish buckle tooltip when buckled to a chair displays a large box of text describing being buckled when your mouse hovers over said tooltip/icon thing. Issue is that if you move your mouse above the icon and around the screen, the text box stays up so long as you remain buckled and takes up a lot of that sweet sweet screen space. I have also seen the text box bug out if it remains up round end causing a white box to remain where the text was going into the next round. Furthermore, once the text box is stuck up there, moving the mouse over the buckled icon seems to confuse the game and the text box goes away and comes back. I am particularly affected due to having a 2nd monitor above the first which means if I move my mouse to the upper monitor over the buckled icon, I am stuck with the text box. My screen cap does not show my mouse but I assure you, the mouse is not hovering over the buckle button!
image

What's the difference with what should have happened?

Screen space is valuable real estate you know? Having a text box take up that space when you are not wanting to see it should not occur. I know the buckled icon was added somewhat recently so wanted to nip this bit in the bud.

How do we reproduce this bug?

  1. Buckle up buttercup.
  2. Move the mouse over the Buckled icon.
  3. Move the mouse above said icon then around to your normal play area.

Issue Bingo

@Superwelder Superwelder added the Bug Admin events aren't bugs label Dec 30, 2023
github-merge-queue bot pushed a commit that referenced this issue Jan 1, 2024
# About the pull request

Fixes #5344 by making alert tooltips close when the user's mouse exits
the alert.
(This is how it work on other codebases that I've checked, so I guess it
was just accidentally left out when alerts were ported here?)

# Explain why it's good for the game

Tooltips should be able to open *and* close.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Fixed screen alert tooltips ('Buckled' indicator and stuff) getting
stuck open.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant