Sythesis Machine In Research Lab

[RikardSeltz]

Testmerges

12

Round ID

20214

Description of the bug

I was reating a custom healing chem using the sythesis machine which would contain 6 properties: BST, ATX, CSL, DFB, TRF and HGN, after hitting simulate 2 of the 6 chemicals had been deleted as shown in the screenshots provided.

I reported this to the admin team in game during which I spoke to biolock and Hippie who refunded the points used to create the chem. Following this I tried to make another chem with different properties and the same result happened leaving me with 4 out of 6 on the chem paper.

I the then tried to make a chem with only 4 properties and upon sythesis 2 were removed.

(for some reason the rest of my printscreens did not save however I got the one from the first instance here)

Admin Hippie confirmed that even though 6 properties show on the sythesis machine only 4 show on the admin panel.

What's the difference with what should have happened?

Everytime I have used the sythesis machine in the past It has allowed me to make custom chems with 6 properties with all 6 on the paper.

How do we reproduce this bug?

1. Click on the systhesis machine to make a chem
2. Choose 4-6 properties
3. view the result

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Weuyn]

100% skill issue. Don't combine properties that are mutually exclusive. NGN/BCD, CRS/ACR, ATX/TXC, MST/RLX, NRS/PST, etc. etc.

[private-tristan]

literally none of those chemicals conflict i was wrong oops.

cmss13/code/modules/reagents/Chemistry-Generator.dm

Lines 321 to 336 in 787d5fe

	/datum/reagent/proc/insert_property(property, level)
	//The list below defines what properties should override each other.
	var/list/conflicting_properties = list( PROPERTY_NUTRITIOUS = PROPERTY_HEMORRAGING, PROPERTY_NUTRITIOUS = PROPERTY_HEMOLYTIC, PROPERTY_TOXIC = PROPERTY_ANTITOXIC,\
	PROPERTY_CORROSIVE = PROPERTY_ANTICORROSIVE, PROPERTY_BIOCIDIC = PROPERTY_NEOGENETIC, PROPERTY_HYPERTHERMIC = PROPERTY_HYPOTHERMIC,\
	PROPERTY_NUTRITIOUS = PROPERTY_KETOGENIC, PROPERTY_PAINING = PROPERTY_PAINKILLING, PROPERTY_HALLUCINOGENIC = PROPERTY_ANTIHALLUCINOGENIC,\
	PROPERTY_HEPATOTOXIC = PROPERTY_HEPATOPEUTIC, PROPERTY_NEPHROTOXIC = PROPERTY_NEPHROPEUTIC, PROPERTY_PNEUMOTOXIC = PROPERTY_PNEUMOPEUTIC,\
	PROPERTY_OCULOTOXIC = PROPERTY_OCULOPEUTIC, PROPERTY_CARDIOTOXIC = PROPERTY_CARDIOPEUTIC, PROPERTY_NEUROTOXIC = PROPERTY_NEUROPEUTIC,\
	PROPERTY_FLUXING = PROPERTY_REPAIRING, PROPERTY_RELAXING = PROPERTY_MUSCLESTIMULATING, PROPERTY_HEMOGENIC = PROPERTY_HEMOLYTIC,\
	PROPERTY_HEMOGENIC = PROPERTY_HEMORRAGING, PROPERTY_NUTRITIOUS = PROPERTY_EMETIC,\
	PROPERTY_HYPERGENETIC = PROPERTY_NEOGENETIC, PROPERTY_HYPERGENETIC = PROPERTY_HEPATOPEUTIC, PROPERTY_HYPERGENETIC = PROPERTY_NEPHROPEUTIC,\
	PROPERTY_HYPERGENETIC = PROPERTY_PNEUMOPEUTIC, PROPERTY_HYPERGENETIC = PROPERTY_OCULOPEUTIC, PROPERTY_HYPERGENETIC = PROPERTY_CARDIOPEUTIC,\
	PROPERTY_HYPERGENETIC = PROPERTY_NEUROPEUTIC, PROPERTY_ADDICTIVE = PROPERTY_ANTIADDICTIVE, PROPERTY_NEUROSHIELDING = PROPERTY_NEUROTOXIC,\
	PROPERTY_HYPOMETABOLIC = PROPERTY_HYPERMETABOLIC, PROPERTY_HYPERTHROTTLING = PROPERTY_NEUROINHIBITING,
	PROPERTY_FOCUSING = PROPERTY_NERVESTIMULATING, PROPERTY_THERMOSTABILIZING = PROPERTY_HYPERTHERMIC, PROPERTY_THERMOSTABILIZING = PROPERTY_HYPOTHERMIC,
	PROPERTY_AIDING = PROPERTY_NEUROINHIBITING, PROPERTY_OXYGENATING = PROPERTY_HYPOXEMIC, PROPERTY_ANTICARCINOGENIC = PROPERTY_CARCINOGENIC, \
	PROPERTY_CIPHERING = PROPERTY_CIPHERING_PREDATOR, PROPERTY_TRANSFORMATIVE = PROPERTY_ANTITOXIC)

I made an issue similar to this one #4235, but it had to do with research chems combining and deleting properties that had nothing to do with the combination

[Weuyn]

Check the very last combination on that list against the properties Seltz tried to put into that chemical. Transformative, Anti-toxic.

[RikardSeltz]

TRF heals the brute & burn but deals toxic damage to the user and the Anti Tox was added to counter the negative effect to save dylovene usage. Is it possible in the Code of the game that putting these 2 traits together could cause a confliction not known about to the developers?

[Lukas-Seltz]

Check the very last combination on that list against the properties Seltz tried to put into that chemical. Transformative, Anti-toxic.

Alright, so why was that conflict placed in the code? It does not make any sense why you would not be able to use transformative and Anti tox as the anti tox cancels out the damage done by transformative.

[Weuyn]

That's exactly why they are mutually exclusive, so that TRF is not free healing.

[Lukas-Seltz]

That's exactly why they are mutually exclusive, so that TRF is not free healing.

That is really bad logic as many other chems are free healing. Such as god chems where you will never die by your logic that means they should not exist.