Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weeded corpses don't update color when turned forsaken #5370

Closed
2 of 3 tasks
private-tristan opened this issue Jan 3, 2024 · 0 comments · Fixed by #5371
Closed
2 of 3 tasks

Weeded corpses don't update color when turned forsaken #5370

private-tristan opened this issue Jan 3, 2024 · 0 comments · Fixed by #5371
Labels
Bug Admin events aren't bugs

Comments

@private-tristan
Copy link
Contributor

Testmerges

#5298: 'Polish Dropship Weapons UI' by Drulikar at commit ea03c59 #5153: 'Status Effects - Part 3A (v2) - Daze Refactor' by fira at commit 9863c4e #5086: 'Adds the XM51 Breaching Scattergun' by VileBeggar at commit 9f4c7ef #5337: 'Fixes playing cards' by fira at commit 3b08cf3 #5280: 'Changes to bone repairing' by BeagleGaming1 at commit 00c0fd1 #5278: 'Xenos now see marines on the tacmap during hijack if xenos outnumber marines for more than 25%' by ihatethisengine at commit fa3d810 #5122: 'Pylons now count only groundside marines, xenos get major boost to evo speed for 3 minutes after hijack' by ihatethisengine at commit e2f845c #5359: 'Fix simulators demolition button' by Drulikar at commit a870fee #5336: 'A couple of M56D/M2C fixes' by SabreML at commit 771bc98 #5228: 'Reduces the burst multiplier on the M39' by VileBeggar at commit 74a1f99

Round ID

20223

Description of the bug

corpse after forsaken spawned
image
placed a resin node under it and it updated its' color to forsaken
image

What's the difference with what should have happened?

should have been picture 2 from the start

How do we reproduce this bug?

1.kill something
2. wait for weeds to grow over it
3. hijack
4. evac
5. look at the corpse with weeds
...

Issue Bingo
@private-tristan private-tristan added the Bug Admin events aren't bugs label Jan 3, 2024
@Drulikar Drulikar mentioned this issue Jan 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 6, 2024
@Drulikar
Add forsaken handling to weeded corpses (#5371)
c7f2498 
# About the pull request

This PR adds the forsaken handling signal to weed_food so they can
change color when the weeds change hives. Unfortunately the weeds don't
change color immediately, so I must just force the color in weed_food
rather than read what color the weeds are.

# Explain why it's good for the game

Fixes #5370 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![forsaken](https://github.com/cmss13-devs/cmss13/assets/76988376/bdf72d7f-9a90-44e2-9be7-55ac917cfaad)

</details>


# Changelog
:cl: Drathek
fix: Fixed weeded corpses not changing color during forsaken conversion
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add forsaken handling to weeded corpses Drulikar/cmss13
1 participant
@private-tristan