Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulture spotter kit teleports you #5385

Closed
3 tasks done
Red-byte3D opened this issue Jan 4, 2024 · 0 comments · Fixed by #5832
Closed
3 tasks done

Vulture spotter kit teleports you #5385

Red-byte3D opened this issue Jan 4, 2024 · 0 comments · Fixed by #5832
Labels
Bug Admin events aren't bugs

Comments

@Red-byte3D
Copy link
Contributor

Red-byte3D commented Jan 4, 2024 •
edited
Loading

Testmerges

#5298 #5113 #5285 #5153 #5086 #5337 #5280 #5278 #5122 #5359 #5336 #5228

Round ID

No response

Description of the bug

if you RESIST after you are moved from the spotter bino, aka dragging, oppressor pull, fling vanguard fling ETC you stay in the zoom menu but if you click exist scope or press resist, you are then teleported back to the original location of the spotter, no matter how far away you are. (you also cannot move when you get dragged / moved)

What's the difference with what should have happened?

not this

How do we reproduce this bug?

  1. look down vulture spotter binos
  2. get dislocated
  3. resist to get teleported back to the spotter binos
    ...

Issue Bingo
@Red-byte3D Red-byte3D added the Bug Admin events aren't bugs label Jan 4, 2024
@Zonespace27 Zonespace27 mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
@Zonespace27
Fixes the M707 spotting scope teleporting its user and M707 attachmen…
e2e5fce 
…t camo (#5832)

# About the pull request
Adds some extra checks to the spotting scope to kick a user out if more
things (going prone, dying, moving) occurs.
Also fixes an issue where m707 attachments weren't reflecting their maps
camo despite having the sprites to do so.

Closes #5385

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/41448081/5fcdbe5f-37e4-4180-a73c-aa5019b326d3)


![image](https://github.com/cmss13-devs/cmss13/assets/41448081/dbf2d46c-a425-4979-a2e0-b9db2016c489)

</details>


# Changelog
:cl:
fix: M707 spotting scope should no longer teleport its user.
fix: M707's attachments should now correctly reflect the map's
camouflage.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes the M707 spotting scope teleporting its user and M707 attachment camo Zonespace27/cmss13
1 participant
@Red-byte3D