ERT Disregarding Player Role Preference

[Katskan]

Testmerges

#5086: 'Adds the XM51 Breaching Scattergun' by VileBeggar at commit 1a300ef #5337: 'Fixes playing cards' by fira at commit 3b08cf3 #5228: 'Reduces the burst multiplier on the M39' by VileBeggar at commit 74a1f99 #5007: 'Project ARES TM Holder (v4)' by realforest2001 at commit 2b8b3d2 #5435: 'TGUI upgrades to support react migration' by mullenpaul at commit 971a2f7 #5397: 'A slurry of Bigred changes' by spartanbobby at commit 57f6fc3 #5280: 'Changes to bone repairing' by BeagleGaming1 at commit cfad5f2 #5464: 'Fixes mobs unable to move after being flung while buckled.' by Birdtalon at commit 97593cf #5480: 'Plastic Crate' by realforest2001 at commit 265b49b

Round ID

20439

Description of the bug

So when you go into character preferences, and do special role setup for ERT roles, even if you say "No" to rifleman/miscellaneous roles you can still be spawned as one against your wishes.

What's the difference with what should have happened?

Setting your preference to "No" on misc/other roles should properly prevent you from spawning as one of those, and let someone who wants to play that role take your place in the ERT

How do we reproduce this bug?

1. Go to edit characters, special roles, set misc to No
2. Successfully roll for ERT
3. Still spawn as rifleman

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)