Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad Shivas Survivor #5530

Closed
3 tasks done
Staykeu opened this issue Jan 24, 2024 · 1 comment · Fixed by #5533
Closed
3 tasks done

Bad Shivas Survivor #5530

Staykeu opened this issue Jan 24, 2024 · 1 comment · Fixed by #5533
Labels
Bug Admin events aren't bugs

Comments

@Staykeu
Copy link
Contributor

Staykeu commented Jan 24, 2024

Testmerges

#5086: 'Adds the XM51 Breaching Scattergun' by VileBeggar at commit 1a300ef #5007: 'Project ARES TM Holder (v4)' by realforest2001 at commit 9ef47f5 #5493: 'React Migration - part 2' by mullenpaul at commit 707f358 #5392: 'Yautja Weapon Gimmicks, Round Two' by realforest2001 at commit bcd8b2b #5490: 'Requisition Centralization [Part 1]' by ItsVyzo at commit f756754 #5525: 'Fix Weird Inventories' by Drulikar at commit 4787757 #5515: 'Nerfs GAU damage by one fifth.' by Birdtalon at commit 3586ae2

Round ID

20532

Description of the bug

During a survivor round on Shiva's Snowball, I spawned in as a pre-starving survivor with a botanist's apron instead of an insulating jacket. Due to this I was left behind and eventually captured. Before I was captured, I was taking damage from the weather and became extremely slow from both the weather damage and lack of nutrition.

What's the difference with what should have happened?

I believe survivors are supposed to spawn with full nutrition, and spawn with insulating wear on snow maps.

How do we reproduce this bug?

Roll survivor on Shiva's Snowball under the "Any" survivor preference before the round starts.

Issue Bingo
@Staykeu Staykeu added the Bug Admin events aren't bugs label Jan 24, 2024
@private-tristan
Copy link
Contributor

This bug appears to only occur with civilian type survivors, as all others have cold/map specific versions.

shivas has "/datum/equipment_preset/survivor/civilian" as a survivor type, but if there's a cold map it should be forcing civilian survs to spawn with snowgear

cmss13/code/modules/gear_presets/survivors/misc.dm

Lines 92 to 93 in 1bf868c

if(SSmapping.configs[GROUND_MAP].environment_traits[MAP_COLD])
add_ice_colony_survivor_equipment(new_human)

cmss13/code/modules/gear_presets/_select_equipment.dm

Lines 683 to 691 in 1bf868c

/datum/equipment_preset/proc/add_ice_colony_survivor_equipment(mob/living/carbon/human/new_human)
if((SSmapping.configs[GROUND_MAP].environment_traits[MAP_COLD]) && (SSmapping.configs[GROUND_MAP].map_name != MAP_CORSAT))
new_human.equip_to_slot_or_del(new /obj/item/clothing/head/ushanka(new_human), WEAR_HEAD)
new_human.equip_to_slot_or_del(new /obj/item/clothing/suit/storage/snow_suit/survivor(new_human), WEAR_JACKET)
new_human.equip_to_slot_or_del(new /obj/item/clothing/mask/rebreather/scarf(new_human), WEAR_FACE)
new_human.equip_to_slot_or_del(new /obj/item/clothing/shoes/marine/knife(new_human), WEAR_FEET)
new_human.equip_to_slot_or_del(new /obj/item/clothing/gloves/black(new_human), WEAR_HANDS)

image

@private-tristan private-tristan mentioned this issue Jan 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2024
@private-tristan
Civilian survs now spawn with snow gear (#5533)
92f00bd 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

# About the pull request
snow map survs now spawn with snow gear. previously they wouldn't due to
their random equipment getting picked first, leading to them not getting
any snowgear and freezing to death. fixes #5530

sadly this means that they lose most of their unique gear, but I guess
the alternative is freezing to death instantly.
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

survs should at least have a chance to survive? maybe?
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding, and may discourage maintainers from reviewing or merging
your PR. This section is not strictly required for (non-controversial)
fix PRs or backend PRs. -->


# Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->
<details>
<summary>I got a picture</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/54422837/849508c8-f88d-472b-8082-724aa6470cc1)

</details>


# Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
label your changes in the changelog. Please note that maintainers freely
reserve the right to remove and add tags should they deem it
appropriate. You can attempt to finagle the system all you want, but
it's best to shoot for clear communication right off the bat. -->
<!-- If you add a name after the ':cl', that name will be used in the
changelog. You must add your CKEY after the CL if your GitHub name
doesn't match. Maintainers freely reserve the right to remove and add
tags should they deem it appropriate. -->

:cl:
fix: Civilian survs will now spawn with snow gear on snow maps.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Civilian survs now spawn with snow gear private-tristan/cmss13
2 participants
@private-tristan @Staykeu