Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked AHelps do not react to 3rd party responses. #5547

Closed
3 tasks done
blackdragonTOW opened this issue Jan 25, 2024 · 1 comment · Fixed by #5779
Closed
3 tasks done

Marked AHelps do not react to 3rd party responses. #5547

blackdragonTOW opened this issue Jan 25, 2024 · 1 comment · Fixed by #5779
Labels
Admin Make things harder for admins Oversight Test your code rigorously only for you to overlook something ultra obvious

Comments

@blackdragonTOW
Copy link
Contributor

Testmerges

#5086: 'Adds the XM51 Breaching Scattergun' by VileBeggar at commit 1a300ef #5007: 'Project ARES TM Holder (v4)' by realforest2001 at commit 9ef47f5 #5392: 'Yautja Weapon Gimmicks, Round Two' by realforest2001 at commit bcd8b2b #5490: 'Requisition Centralization [Part 1]' by ItsVyzo at commit 87a1feb #5525: 'Fix Weird Inventories' by Drulikar at commit 4787757 #5515: 'Nerfs GAU damage by one fifth.' by Birdtalon at commit 3586ae2

Round ID

No response

Description of the bug

If staff marks an AHelp, it is marked as being responded on the ticket, but does not tell others of that if they try to respond.

What's the difference with what should have happened?

Presently, if Admin 1 Replies to a ticket and Admin 2 clicks "Reply", Admin 2 will get a sound and a notification that Admin 1 is in the process of Replying.

With Marking, none of those safe guards are there. If Admin 1 Marks a ticket, Admin 2 can click on reply without knowing that it's Marked. In the inverse, if Admin 1 Replies to a ticket, Admin 2 can Mark it without knowing that it's being Replied to.

How do we reproduce this bug?

  1. Generate an AHelp ticket
  2. Mark the ticket with person 1
  3. Click reply with person 2
  4. ---> There is no feedback that this is already being handled
    ...

Issue Bingo
@blackdragonTOW blackdragonTOW added the Bug Admin events aren't bugs label Jan 25, 2024
@ItsVyzo
Copy link
Contributor

ItsVyzo commented Jan 25, 2024 •
edited
Loading

Same applies for Auto response/Reject/Close/Resolve/Defer

@ItsVyzo ItsVyzo added Admin Make things harder for admins Oversight Test your code rigorously only for you to overlook something ultra obvious and removed Bug Admin events aren't bugs labels Jan 25, 2024
@harryob harryob mentioned this issue Feb 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 25, 2024
@harryob
makes marking more effective for admins (#5779)
723b6c2 
marking a ticket now actually stops others from interacting from it.
other admins can still override it by hitting "mark" themselves, and
them "override" and doing whatever they want to it.

:cl:
admin: marking a ticket now actually stops other people from messing
with your marked ticket
/:cl:

fixes #5547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Admin Make things harder for admins Oversight Test your code rigorously only for you to overlook something ultra obvious
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

makes marking more effective for admins harryob/cmss13
2 participants
@blackdragonTOW @ItsVyzo