Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire Controll on CAS shows wrong ammo usage #5578

Closed
3 tasks done
Oyu07 opened this issue Jan 28, 2024 · 1 comment · Fixed by #5824
Closed
3 tasks done

Fire Controll on CAS shows wrong ammo usage #5578

Oyu07 opened this issue Jan 28, 2024 · 1 comment · Fixed by #5824
Assignees
@mullenpaul
Labels
Bug Admin events aren't bugs UI deletes nanoui/html

Comments

@Oyu07
Copy link
Contributor

Oyu07 commented Jan 28, 2024

Testmerges

#5086, #5392, #5452, #5526, #5506, #5519, #5007

Round ID

No response

Description of the bug

Ammo used per run is incorrect, and goes up as you do less steps rather than going down

What's the difference with what should have happened?

It straight up shows the wrong ammo used

How do we reproduce this bug?

  1. Use the fire control
  2. Use GAU-21
  3. Change steps and observe numbers

Same goes for others, like mini rocket pod will say 10 rockets per run

TdKaIR6k1r

Issue Bingo
@Oyu07 Oyu07 added the Bug Admin events aren't bugs label Jan 28, 2024
@mullenpaul mullenpaul added the UI deletes nanoui/html label Jan 28, 2024
@mullenpaul mullenpaul mentioned this issue Feb 26, 2024
Merged
@mullenpaul
Copy link
Contributor

Thank you for reporting this issue. I have raised a PR to fix this.

github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
@mullenpaul
Fix cas ammo consumption logic (#5824)
7eafea9 
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->
Fix #5578
# Explain why it's good for the game
Bugs bad
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: ammo consumption logic for cas tgui correctly counts
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mullenpaul mullenpaul

Labels
Bug Admin events aren't bugs UI deletes nanoui/html
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cas ammo consumption logic mullenpaul/cmss13
2 participants
@Oyu07 @mullenpaul