Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helmet welding HUD non functional and causes runtime #5656

Closed
3 tasks done
Birdtalon opened this issue Feb 3, 2024 · 0 comments · Fixed by #5660
Closed
3 tasks done

Helmet welding HUD non functional and causes runtime #5656

Birdtalon opened this issue Feb 3, 2024 · 0 comments · Fixed by #5660
Labels
Bug Admin events aren't bugs

Comments

@Birdtalon
Copy link
Contributor

Birdtalon commented Feb 3, 2024 •
edited
Loading

Testmerges

#5007 #5392 #5552 #5649 #5628

Round ID

20719

Description of the bug

Trying to switch helmet HUDs while having a welding visor does nothing and causes a runtime.

RUNTIME: Cannot read null.hudusers - code/modules/clothing/head/helmet.dm@697 (600 total)

From #5600

What's the difference with what should have happened?

You should be able to turn on/switch helmet HUDs

How do we reproduce this bug?

  1. Spawn as a marine or comtech
  2. Put a welding helmet visor into your helmet
  3. Try to enable switch helmet hud.

Issue Bingo
@Birdtalon Birdtalon added the Bug Admin events aren't bugs label Feb 3, 2024
@Drulikar Drulikar mentioned this issue Feb 4, 2024
Merged
@Birdtalon Birdtalon changed the title Helmet HUDs non functional Helmet welding HUD non functional and causes runtime Feb 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2024
@Drulikar
Add null conditional operators to helmet code (#5660)
59b6267 
# About the pull request

So I am not able to reproduce the runtime spam errors reported in #5656
prompting #5655 but I have added null conditional operators where it is
complaining.

# Explain why it's good for the game

Less runtimes? Fixes #5656

# Testing Photographs and Procedure
Untested other than confirming it still seems fine? Please let me know
if you know how to reproduce it.

# Changelog
:cl: Drathek
fix: Added more null testing to helmet visors.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add null conditional operators to helmet code Drulikar/cmss13
1 participant
@Birdtalon