Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text not showing properly #5714

Closed
3 tasks done
FighterOfKeyboard opened this issue Feb 13, 2024 · 0 comments · Fixed by #5722
Closed
3 tasks done

Text not showing properly #5714

FighterOfKeyboard opened this issue Feb 13, 2024 · 0 comments · Fixed by #5722
Labels
Bug Admin events aren't bugs

Comments

@FighterOfKeyboard
Copy link

Testmerges

#5007,#5392,#5552,#5628,#5542,#5584,#3633

Round ID

20871

Description of the bug

image
image

not sure why but the text is not finished as it only says "It is somewhat".

What's the difference with what should have happened?

the text should be something like "it is about half full"

How do we reproduce this bug?

1.take a magazine thats half full(ive used a M41A mag)
2.bash it against your helmet

Issue Bingo
@FighterOfKeyboard FighterOfKeyboard added the Bug Admin events aren't bugs label Feb 13, 2024
@Vicacrov Vicacrov mentioned this issue Feb 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2024
@Vicacrov
Fixes ammo magazine checking with helmet if the mag is exactly half f…
aa11675 
…ull (#5722)

# About the pull request

Hitting an ammo magazine against your helmet had a faulty examine text
if the mag had exactly half of its capacity.

Fixes #5714 

# Explain why it's good for the game

Not having cut off text in the game is

# Testing Photographs and Procedure

Here:

<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/49321394/ca96275f-e3ea-4530-8965-5cb39b62cf10)


![image](https://github.com/cmss13-devs/cmss13/assets/49321394/f0f54765-f1e4-44c7-9b9e-7161b2a8103c)


![image](https://github.com/cmss13-devs/cmss13/assets/49321394/0014c882-65b7-4311-ad6a-263d7a7f1c31)


![image](https://github.com/cmss13-devs/cmss13/assets/49321394/a46c3d73-ce04-4e95-8787-e3a172daa444)


![image](https://github.com/cmss13-devs/cmss13/assets/49321394/9bda789a-3f33-41ee-a0e7-777c8200b814)

</details>


# Changelog

:cl:
fix: Fixes a missing examine text when you hit an exactly half-full ammo
magazine against your helmet.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes ammo magazine checking with helmet if the mag is exactly half full Vicacrov/cmss13
1 participant
@FighterOfKeyboard