Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPP ERT Synthetic has the skillset of a Private #5853

Closed
3 tasks done
dadlips opened this issue Mar 1, 2024 · 0 comments · Fixed by #5854
Closed
3 tasks done

UPP ERT Synthetic has the skillset of a Private #5853

dadlips opened this issue Mar 1, 2024 · 0 comments · Fixed by #5854
Labels
Bug Admin events aren't bugs

Comments

@dadlips
Copy link

dadlips commented Mar 1, 2024

Testmerges

N/A

Round ID

21099

Description of the bug

image

#5830 May have messed up the skillset for certain ERT synths, the UPP one at least had null skills and had to all be setup.

What's the difference with what should have happened?

ERT synths need their skillsets

How do we reproduce this bug?

  1. Spawn in as a UPP ERT synth, possibly others that 5830 touched
  2. No skills :(

Issue Bingo
@dadlips dadlips added the Bug Admin events aren't bugs label Mar 1, 2024
@Drulikar Drulikar mentioned this issue Mar 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 3, 2024
@Drulikar
Fix UPP & CLF Synth Skills (#5854)
255bbc5 
# About the pull request

This PR is a follow up to #5830 And also fixes the incorrect defines
(used for name) of colony synth gen 1 and 2.

# Explain why it's good for the game
Fixes #5853 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/c7c6bfb9-fc6c-4c38-a6c7-3941179c313f)

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/5a9bf223-30db-4e7c-a821-f4f79a4e4313)

</details>


# Changelog
:cl: Drathek
fix: Fixed skills not getting set for UPP and CLF synths
spellcheck: Fixed naming of colony synth gen 1 and gen 2 being swapped
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UPP & CLF Synth Skills Drulikar/cmss13
1 participant
@dadlips