Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite Issue on Pillbottles #5931

Closed
3 tasks done
Lagomorphica opened this issue Mar 13, 2024 · 1 comment · Fixed by #5932
Closed
3 tasks done

Sprite Issue on Pillbottles #5931

Lagomorphica opened this issue Mar 13, 2024 · 1 comment · Fixed by #5932
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@Lagomorphica
Copy link
Contributor

Lagomorphica commented Mar 13, 2024

Testmerges

#5401: 'M540-A Armored Recon Carrier' by Zonespace27 at commit 9be4807
#5887: 'Pizza Station is back on the menu' by Nanu308 at commit c9aae15
#5696: 'Legcuffs work' by realforest2001 at commit 6767262
#5006: 'Project ARES: Added Tech Unlock logs' by realforest2001 at commit c0645ab
#5927: 'use world.Export instead of rustg http for byond account age' by harryob at commit ed4283b
#5724: 'XM43E1 in regular gameplay' by Releasethesea at commit 9f897ae
#5763: 'Map: Bigred change south lambda padlock and turned it into a checkpoint.' by Huffie56 at commit 646c477
#5838: 'Resprites - 2/2024 Edition' by nauticall at commit 59743e1

Round ID

21290

Description of the bug

Pill bottles are missing the cap sprite like on the Resprites - 2/2024 Edition PR. Image will show the difference between the provided PR and what was in game.

308054557-00c0ca83-ddd1-4e96-a692-6db5a6095dac

This was the provided image of what the pill bottles are supposed to look like. Note the white cap on top to give depth.

This is what is visible in game (in belt and on floor)

image

image

What's the difference with what should have happened?

The sprites should have a noticeable cap or lid on them. The sprites of empty pill bottles (that is, pill bottles you get in boxes from Chemistry) have an open lid on them. I am not certain on if these pill bottles are supposed to have an opened sprite either but they lack them, assuming that is needed.

How do we reproduce this bug?

  1. Get a pill bottle.
  2. Look at it.

Issue Bingo

@Lagomorphica Lagomorphica added the Bug Admin events aren't bugs label Mar 13, 2024
@Drulikar Drulikar added the Confirmed Bug We have the same at home! label Mar 13, 2024
@Drulikar
Copy link
Contributor

Looks like the pills_closed state in chemistry.dmi got lost sometime between the time the PR was opened and when it was merged.

@Drulikar Drulikar linked a pull request Mar 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants