Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch-Storing-Drawing-Method doesn't work on drop pouches. #6089

Closed
3 tasks done
gitbirb opened this issue Apr 5, 2024 · 1 comment · Fixed by #7059
Closed
3 tasks done

Switch-Storing-Drawing-Method doesn't work on drop pouches. #6089

gitbirb opened this issue Apr 5, 2024 · 1 comment · Fixed by #7059
Labels
Bug Admin events aren't bugs

Comments

@gitbirb
Copy link

gitbirb commented Apr 5, 2024

Testmerges

#5938: 'Adds Shockwaves to Explosions and Xeno Screeches ' by GrrrKitten at commit 23c093f #5914: 'Ports stripping menu from TG' by ihatethisengine at commit ac0caeb #6020: 'Super Strength Grab Changes (Never skip arm day)' by Ben10083 at commit 9246532 #6015: 'Colony Synthetic variants with a refresh' by QuickLode at commit c6f1f9a #6040: 'Better throw logic' by Git-Nivrak at commit 7314763 #5401: 'M540-B Armored Recon Carrier' by Zonespace27 at commit 6cbd84f #5774: 'Updated XM43E1 for Sniper Spec' by Kaga-404 at commit a054def #6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 20f293b

Round ID

No response

Description of the bug

This is a oversight that's been around, probably for quite a long time

//

When using these freeform storage items, you cannot set them to draw on click.
image

It makes sense with the satchel, G8-A pouch, and general pouches, since they have no option to do so, However -
image
For the drop pouch, it does have an option. It just doesn't work.

What's the difference with what should have happened?

Either the drop pouch should not have the option (like similar storage items) so that it's less confusing
Or it should be able to be drawn from by click.

How do we reproduce this bug?

  1. Get a drop pouch from Surplus Uniform Vendor
  2. Place it on your uniform
  3. Attempt to Switch-Storage-Drawing-Method
  4. It does nothing.
    ...

Issue Bingo

@gitbirb gitbirb added the Bug Admin events aren't bugs label Apr 5, 2024
@rythenx
Copy link
Contributor

rythenx commented Aug 29, 2024

This is still occurring. I might see if I can find the cause and raise a PR.

github-merge-queue bot pushed a commit that referenced this issue Sep 10, 2024
# About the pull request
Drop pouches currently show the option to toggle storage drawing method
but when you click it, it does nothing. You can already alt-click drop
pouches to draw the last item but there isn't a way to make it so that
the default click draws the last item (or first item).

I have tested this locally and it correctly lets you toggle the storage
mode after making this change.

fixes #6089

# Explain why it's good for the game

Since you can already alt-click drop pouches to draw the last item, this
just makes it slightly more convenient so that you can set the default
to that behaviour like you can with most other pouches. This also lets
you toggle between the FIFO mode as well which is something you can't do
via alt click.


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog

:cl:
fix: drop pouch's switch storage drawing method now works correctly
instead of doing nothing
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants