Normandy's starboard pylons suddenly disappear during setup time

[hminh2010]

Testmerges

#5401: 'M540-B Armored Recon Carrier' by Zonespace27 at commit 14fd730 #6103: 'Med Vendor Rebalance' by Drulikar at commit bfdc7f3 #5957: 'OT CAS rocket' by iloveloopers at commit fb68496 #6114: 'dehardcodes client version warnings' by harryob at commit 653037e #6062: 'Stabilized metallic foam, a gimmick new flamer fuel' by iloveloopers at commit eb2a451 #6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 0079ca1

Round ID

21804

Description of the bug

While I was setting up Normandy for CAS during the fueling period during pre-op, every weapon and engine point on the starboard side of the Normandy suddenly disappeared. Attempting to interact with the points, such as clicking on it with a powerloader to attempt to uninstall whatever was on there, or trying to install a new one, did nothing.

What's the difference with what should have happened?

Normandy's weapons should not have disappeared.

How do we reproduce this bug?

The DP was helping me install the components, so I am not sure of the exact order, but I installed the following components, in this rough order:

• Guided Missile Rack, on the starboard wing weapon attach point
• Laser, on the starboard fore weapon attach point
• Cooling system, on the starboard engine attach point
• Targeting Pod, on the starboard electronics mount
• Rocket Pod on the port wing attach point
• Cooling system, on the port engine attach point
  At this point, the starboard mounts, except for the targeting pod, suddenly disappear.

It is worth noting that the cooling system which I put on the port mount did not look like a normal one; rather then looking like this:

It looked like this, but detached from the engine mount.

I proceeded to install a Laser and Targeting Pod on the port side after this.
When I viewed the computer at this time, the mounts were visible when setting up Fire Missions, though without ammo they couldn't be assigned to fire anything.

The port side was completely unaffected, however.

I Ahelped this, at which point the admin tries to fix it. They told me that they couldn't fix it, and that, "Be sure to say that VV'ing the STARBOARD WING ATTACH POINT shows whatever is in the PORT WING ATTACH POINT, and deleting it from the STARBOARD one deletes it from the PORT one. Nothing can be placed on the whole starboard side of the dropship."

At this point, I decided to swap out the port side Laser and Rocket Pod for more Guided Missile Racks and loaded them with a Dragon's Breath and a Widowmaker, hoping to do direct missions. However, after doing that and flying a flyby mission, the targeting computer completely removed all listed weapons in the FM, as well as listing no weapons to do directs with:


At this same time I noticed that none of the equipment which requires a console worked either, e.g the Fulton I had on board.

However, I was able to do Medevacs just fine.

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[dadlips]

I'm not really sure how this managed to happen. In this image you can see that I'm VV'ing the STARBOARD pylon, and it's showing me what is on the PORT pylon. If I were to delete the rocket pod, it would remove it from the PORT pylon, and the STARBOARD pylon will still be unusable.

a few runtimes fired for the weapons systems.

[2024-04-18 02:05:40.667] runtime error: Cannot read null.attach_id

• proc name: get sanitised equipment (/obj/structure/machinery/computer/dropship_weapons/proc/get_sanitised_equipment)
• source file: code/game/machinery/computer/dropship_weapons.dm,543
• usr: Lang Lang (/mob/living/carbon/human)
• src: the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2)
• usr.loc: the floor (92,58,3) (/turf/open/shuttle/dropship)
• src.loc: the floor (92,59,3) (/turf/open/shuttle/dropship)
• call stack:
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): get sanitised equipment(Lang Lang (/mob/living/carbon/human), Normandy (/obj/docking_port/mobile/marine_dropship/normandy))
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui data(Lang Lang (/mob/living/carbon/human))
• /datum/tgui (/datum/tgui): get payload(null, 1, 1)
• /datum/tgui (/datum/tgui): open()
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): tgui interact(Lang Lang (/mob/living/carbon/human), /datum/tgui (/datum/tgui))
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui interact(Lang Lang (/mob/living/carbon/human), "main", null, 0)
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): attack hand(Lang Lang (/mob/living/carbon/human), /list (/list))
• Lang Lang (/mob/living/carbon/human): UnarmedAttack(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), 1, /list (/list))
• Lang Lang (/mob/living/carbon/human): click adjacent(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), null, /list (/list))
• Lang Lang (/mob/living/carbon/human): do click(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), the floor (92,59,3) (/turf/open/shuttle/dropship), "icon-x=14;icon-y=14;left=1;but...")
• Hminh2010 (/client): Click(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), the floor (92,59,3) (/turf/open/shuttle/dropship), "mapwindow.map", "icon-x=14;icon-y=14;left=1;but...")

[2024-04-18 02:05:40.667] runtime error: Cannot read null.attach_id

• proc name: ui data (/datum/cas_fire_mission_record/ui_data)
• source file: code/modules/dropships/cas/fire_mission_record.dm,10
• usr: Lang Lang (/mob/living/carbon/human)
• src: /datum/cas_fire_mission_record (/datum/cas_fire_mission_record)
• usr.loc: the floor (92,58,3) (/turf/open/shuttle/dropship)
• call stack:
• /datum/cas_fire_mission_record (/datum/cas_fire_mission_record): ui data(Lang Lang (/mob/living/carbon/human))
• HIGHWAY TO THE DANGER ZONE (/datum/cas_fire_mission): ui data(Lang Lang (/mob/living/carbon/human))
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): get firemission data(Lang Lang (/mob/living/carbon/human))
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui data(Lang Lang (/mob/living/carbon/human))
• /datum/tgui (/datum/tgui): get payload(null, 1, 1)
• /datum/tgui (/datum/tgui): open()
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): tgui interact(Lang Lang (/mob/living/carbon/human), /datum/tgui (/datum/tgui))
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui interact(Lang Lang (/mob/living/carbon/human), "main", null, 0)
• the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): attack hand(Lang Lang (/mob/living/carbon/human), /list (/list))
• Lang Lang (/mob/living/carbon/human): UnarmedAttack(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), 1, /list (/list))
• Lang Lang (/mob/living/carbon/human): click adjacent(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), null, /list (/list))
• Lang Lang (/mob/living/carbon/human): do click(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), the floor (92,59,3) (/turf/open/shuttle/dropship), "icon-x=14;icon-y=14;left=1;but...")
• Hminh2010 (/client): Click(the 'Normandy' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), the floor (92,59,3) (/turf/open/shuttle/dropship), "mapwindow.map", "icon-x=14;icon-y=14;left=1;but...")

[hminh2010]

Haven't tested this out yet but I think this is related to another bug, #5848. I'm pretty sure the DP who was helping me set up Normandy tried to grab the same missile rack as me, got the 'fake' missile rack, and placed it on the Normandy, breaking it.