Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light attachments turning itself back on after being disabled. #6238

Closed
2 of 3 tasks
AudiGzz opened this issue May 4, 2024 · 0 comments · Fixed by #6251
Closed
2 of 3 tasks

Light attachments turning itself back on after being disabled. #6238

AudiGzz opened this issue May 4, 2024 · 0 comments · Fixed by #6251
Labels
Bug Admin events aren't bugs

Comments

@AudiGzz
Copy link

AudiGzz commented May 4, 2024

Testmerges

#5401: 'M540-B Armored Recon Carrier' by Zonespace27 at commit ab0e59f #6103: 'Med Vendor Rebalance' by Drulikar at commit 219a08f #5957: 'OT CAS rocket' by iloveloopers at commit 2484c7b #6150: 'Falling Falcons: Paratroopers Edition' by ihatethisengine at commit 8fead53 #6146: 'Smoke Flamer' by iloveloopers at commit ca1fe84 #6178: 'fences can be shot through' by cuberound at commit 5f3e4af #5265: 'WIP - Paperwork Prefabs' by realforest2001 at commit 831b821

Round ID

22307

Description of the bug

Rail flashlight doesn't stay off, if you toggle it.

What's the difference with what should have happened?

It should stay off if you disable it, not turning itself back on

How do we reproduce this bug?

  1. Equip your gun, turn on the rail light or any light attachment that gets disabled when its in suit storage
  2. Turn the rail light off, holster the gun back in suit storage
  3. take it out again, its enabled.
    ...

Issue Bingo
@AudiGzz AudiGzz added the Bug Admin events aren't bugs label May 4, 2024
@vero5123 vero5123 mentioned this issue May 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 19, 2024
@vero5123 @Drulikar
Fixes light attachments setting and add pref for ammo counter (#6251)
274e7c1 
# About the pull request
Closes #6238, also made the ammo display less spammy. 

:cl:
qol: Toggleable ammo counter, can now cycle between displaying every
fifth or single bullet.
fix: Light attachments will no longer automatically turn on when the
weapon is equipped from suit storage
/:cl:

---------

Co-authored-by: DOOM <N/A>
Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes light attachments setting and add pref for ammo counter
1 participant
@AudiGzz