Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwatch TGUI Crash When Saving Coords Name/Comment #6366

Closed
3 tasks done
dadlips opened this issue Jun 2, 2024 · 2 comments · Fixed by #6370
Closed
3 tasks done

Overwatch TGUI Crash When Saving Coords Name/Comment #6366

dadlips opened this issue Jun 2, 2024 · 2 comments · Fixed by #6370
Labels
Bug Admin events aren't bugs

Comments

@dadlips
Copy link

dadlips commented Jun 2, 2024

Testmerges

N/A

Round ID

22478

Description of the bug

Overwatch Console

×

Main Dashboard

Squad Roles

Squad Monitor

Orbital Bombardment

Tactical Map

Orbital Bombardment

186

LONGITUDE

-290

LATITUDE

Ready

STATUS

Fire

Save

Max 3 stored coordinates. Will overwrite oldest first.

LONG. LAT. COMMENT
186 -290

.

+++++@@@@@@@@@@/++++@@@@@@@@@@/+++++/
+++++@@/++*+*+\@@/+++++/
+++++@@/++++++++\@@/+++++/
+++++@@/++++++++++\@@/+++++/
+++++@@/+++++/+++++@@/+++++/
++++/++++/@@+++++/+++++/
++++++++++/@``@++++++++++/
++++++*+/@````@++++++++/
++++++/@@@@@@@@++++++/

A fatal exception has occurred at 002B:C562F1B7 in TGUI.The current application will be terminated.Send the copy of the following stack trace to an authorizedWeyland-Yutani incident handler at https://github.com/cmss13-devs/cmss13/issues.Thank you for your cooperation.
TypeError: Circular reference in value argument not supported
at D (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:101878)
at stringify (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:102164)
at Byond.sendMessage (http://127.0.0.1:50103/tgui-window-1.html:205:7)
at O (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:100:3433)
at onChange (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:283:357635)
at onBlur (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:178:1729)
at Fn (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17192)
at os (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17351)
at ss (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17408)
at tl (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:38797)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"smellyhippie","interface":"OverwatchConsole","window":{"key":"[0x2007777]-main","size":null,"fancy":1,"locked":0}}

TypeError: Circular reference in value argument not supported
at D (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:101878)
at stringify (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:102164)
at Byond.sendMessage (http://127.0.0.1:50103/tgui-window-1.html:205:7)
at O (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:100:3433)
at onChange (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:283:357635)
at onBlur (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:178:1729)
at Fn (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17192)
at os (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17351)
at ss (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17408)
at tl (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:38797)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"smellyhippie","interface":"OverwatchConsole","window":{"key":"[0x2007777]-main","size":null,"fancy":1,"locked":0}}

TypeError: Circular reference in value argument not supported
at D (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:101878)
at stringify (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:102164)
at Byond.sendMessage (http://127.0.0.1:50103/tgui-window-1.html:205:7)
at O (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:100:3433)
at onChange (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:283:357635)
at onBlur (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:178:1729)
at Fn (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17192)
at os (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17351)
at ss (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17408)
at tl (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:38797)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"smellyhippie","interface":"OverwatchConsole","window":{"key":"[0x2007777]-main","size":null,"fancy":1,"locked":0}}

TypeError: Circular reference in value argument not supported
at D (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:101878)
at stringify (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:384:102164)
at Byond.sendMessage (http://127.0.0.1:50103/tgui-window-1.html:205:7)
at O (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:100:3433)
at onChange (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:283:357635)
at onBlur (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:178:1729)
at Fn (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17192)
at os (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17351)
at ss (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:17408)
at tl (http://cdn.cm-ss13.com/live/2c/asset.2cad297a31880c74247b4d3b54bce4b5.js:9:38797)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"smellyhippie","interface":"OverwatchConsole","window":{"key":"[0x2007777]-main","size":null,"fancy":1,"locked":0}}

Weyland-Yutani (c) 2100-2182 Building better user interfaces.

marine bravo radio headset

x1HOwofZj6

What's the difference with what should have happened?

When adding a 'comment' to your coords as pictured above, TGUI crashes.

How do we reproduce this bug?

  1. Get some coords, and save them.
  2. Try to change the name/comment of the coords.
  3. Overwatch TGUI crash
    ...

Issue Bingo
@dadlips dadlips added the Bug Admin events aren't bugs label Jun 2, 2024
@vero5123
Copy link
Contributor

vero5123 commented Jun 3, 2024 •
edited
Loading

it's because of the tgui refactor i'm pretty sure.

@vero5123
Copy link
Contributor

vero5123 commented Jun 3, 2024 •
edited
Loading 

onChange={(e, value) =>
     act('change_coordinate_comment', {
        comment: value,
         index: coords.index,
       })
}

seems to fix it

@vero5123 vero5123 mentioned this issue Jun 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 4, 2024
@vero5123
Fixes TGUI overwatch console & custom font entry ui runtimes (#6370)
95748ce 
# About the pull request
Fixes #6366.

# Explain why it's good for the game
bug bad

# Changelog
:cl:
fix: Fixes overwatch console coordinate comment UI crash
fix: Fixes chat UI crash after entering a custom font
/:cl:

---------

Co-authored-by: DOOM <N/A>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this issue Jun 9, 2024
@vero5123 @Git-Nivrak
Fixes TGUI overwatch console & custom font entry ui runtimes (cmss13-…
635c851 
…devs#6370)

# About the pull request
Fixes cmss13-devs#6366.

# Explain why it's good for the game
bug bad

# Changelog
:cl:
fix: Fixes overwatch console coordinate comment UI crash
fix: Fixes chat UI crash after entering a custom font
/:cl:

---------

Co-authored-by: DOOM <N/A>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes TGUI overwatch console & custom font entry ui runtimes
2 participants
@vero5123 @dadlips