almayer nuked but not a draw

[zzzmike]

Testmerges

it didn't display until it was too late but next round had #6071: '[V] Sorokyne Strata: fixes and changes .' by Venuska1117 at commit 77b1ffb #6388: 'gayons' by 567Turtle at commit 4f9151f #6334: 'Xenomorph Endgame' by Git-Nivrak at commit 0a23f6e #6400: 'Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now' by GrrrKitten at commit 2927345 #6308: 'Hostile Survivor Rework' by Steelpoint at commit bf51f9e #6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 6f1869d

Round ID

22827

Description of the bug

When self destruct goes off, should be a draw, but this round registered as xeno major

What's the difference with what should have happened?

should end as draw

How do we reproduce this bug?

1. self destruct almayer during hijack
2. see if it's a draw

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Drulikar]

SD doesn't set the result to a draw; its just if

cmss13/code/game/gamemodes/cm_process.dm

Lines 193 to 220 in 4fff70a

	/datum/game_mode/proc/count_humans_and_xenos(list/z_levels = SSmapping.levels_by_any_trait(list(ZTRAIT_GROUND, ZTRAIT_RESERVED, ZTRAIT_MARINE_MAIN_SHIP)))
	var/num_humans = 0
	var/num_xenos = 0
	for(var/mob/M in GLOB.player_list)
	if(M.z && (M.z in z_levels) && M.stat != DEAD && !istype(M.loc, /turf/open/space)) //If they have a z var, they are on a turf.
	if(ishuman(M) && !isyautja(M) && !(M.status_flags & XENO_HOST) && !iszombie(M))
	var/mob/living/carbon/human/H = M
	if(((H.species && H.species.name == "Human") || (H.is_important)) && !H.hivenumber) //only real humans count, or those we have set to also be included
	num_humans++
	else
	var/area/A = get_area(M)
	if(isxeno(M))
	var/mob/living/carbon/xenomorph/xeno = M
	if(!xeno.counts_for_roundend)
	continue
	var/datum/hive_status/xeno_hive = GLOB.hive_datum[xeno.hivenumber]
	if(!xeno_hive || (xeno_hive.need_round_end_check && !xeno_hive.can_delay_round_end(xeno)))
	continue
	if (A.flags_area & AREA_AVOID_BIOSCAN)
	continue
	num_xenos++
	else if(iszombie(M))
	if (A.flags_area & AREA_AVOID_BIOSCAN)
	continue
	num_xenos++
	return list(num_humans,num_xenos)

has a count of 0 humans and 0 xenos, then it is a draw. SD destroys all living mobs on the ship z level.

[zzzmike]

Ah okay thanks. Not sure of the player counts on other areas, might as well close this rather than logdive on something that might not be a bug.