Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picking up dropped predator wrist-blade forces it to stay in your hand #6640

Closed
3 tasks done
Foxtrot13224 opened this issue Jul 7, 2024 · 2 comments · Fixed by #7159
Closed
3 tasks done

Picking up dropped predator wrist-blade forces it to stay in your hand #6640

Foxtrot13224 opened this issue Jul 7, 2024 · 2 comments · Fixed by #7159
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@Foxtrot13224
Copy link
Contributor

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 18cfcab #6400: 'Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now' by GrrrKitten at commit 2927345 #6308: 'Hostile Survivor Rework' by Steelpoint at commit bf51f9e #6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 370c1d5 #6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit d874f97 #6594: 'Ports "Adds a Chat Reliability Layer"' by Git-Nivrak at commit 9b0717a #6568: 'Chemical simulator TGUI' by kiVts at commit 5280d57

Round ID

22946

Description of the bug

A predator died with their wrist-blades extended. When a research cut off the predator's arm to get the wrist-bracers, the blade dropped too. When the blade was picked up by me (Another predator), I was unable to drop it or sheathe it, and had to get an admin to remove it via chopping off my arm and giving me a new one.

What's the difference with what should have happened?

Wrist blade should've either auto-retracted on death or have been made drop-able once disconnected from the wrist-bracers.

How do we reproduce this bug?

  1. Have a predator die with wrist-blades extended.
  2. Chop off one of their arms.
  3. Attempt to pickup dropped wrist-blade.
    ...

Issue Bingo
@Foxtrot13224 Foxtrot13224 added the Bug Admin events aren't bugs label Jul 7, 2024
@private-tristan
Copy link
Contributor

NO_DROP and its consequences.

@ItsVyzo ItsVyzo added the Confirmed Bug We have the same at home! label Aug 27, 2024
@ItsVyzo
Copy link
Contributor

ItsVyzo commented Aug 27, 2024

wrist blades should probably have DELONDROP in addition to NO_DROP

This was referenced Sep 13, 2024
Closed
Merged
Sargeantmuffinman pushed a commit to Sargeantmuffinman/cmss13 that referenced this issue Sep 16, 2024
@deathrobotpunch
fixes undroppable wrist blades (cmss13-devs#7159)
f89fe16 
# About the pull request
fixes cmss13-devs#6640
adds trait DELONDROP to wristblades 
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Pred wristblades now del on drop
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
3 participants
@ItsVyzo @private-tristan @Foxtrot13224