Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyro's fire shield toggles shoulder lamp. #6753

Closed
cm13-issue-bot opened this issue Jul 18, 2024 · 0 comments · Fixed by #6756
Closed

Pyro's fire shield toggles shoulder lamp. #6753

cm13-issue-bot opened this issue Jul 18, 2024 · 0 comments · Fixed by #6756
Labels
Bug Admin events aren't bugs

Comments

@cm13-issue-bot
Copy link

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit e04d971cbe
#6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit fb91839b39
#5829: '(EVENT) Cortical Borers' by realforest2001 at commit 9c9dfb571c
#6400: 'Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now' by GrrrKitten at commit 2927345720
#6737: 'Planted flag bugfix and warcry removal' by Zonespace27 at commit 43f33f81e0
#6308: 'Hostile Survivor Rework' by Steelpoint at commit 423ba8189f
#6742: 'Scout Cloak fix' by kiVts at commit 8e33dcdc45
#6745: 'Sound range ' by kiVts at commit 81428cd37f

Round ID

23119

Description of the bug

Pyro's fire shield (specialist activation two) also toggles your armor's shoulder lamp. I have no way of confirming if its specifically tied to specialist's activation interaction with pyro shield or its specifically specialist activation fault alone.

What's the difference with what should have happened?

It should not toggle your shoulder lamp.

How do we reproduce this bug?

  1. Equip M35 pyrotechnician armor with relevant skills to use the abilities
  2. Use specialist activation two keybind or just click on relevant icon
  3. See that it toggles your shoulder lamp.

Attached logs

N/A

Additional details

  • Author: Nettle
  • Admin: Segrain
  • Note: None
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Jul 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 19, 2024
# About the pull request
Calling the parent of all actions
(#6442) caused a lot of bugs,
this fixes that.

Closes #6755
Closes #6753
Closes #6732 
Closes #6742

# Explain why it's good for the game

Bugs are bad

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Tested on practically every object that has a use-in-hand functionality
with an action button.

</details>


# Changelog
:cl:
fix: Fixed a large amount of objects activating erroneous functionality
(like an armor light) when using action buttons tied to that object.
/:cl:

Co-authored-by: John Doe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant