Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkman play/pause buttons toggle both functions at once #6755

Closed
3 tasks done
TropicalFlak opened this issue Jul 18, 2024 · 0 comments · Fixed by #6756
Closed
3 tasks done

Walkman play/pause buttons toggle both functions at once #6755

TropicalFlak opened this issue Jul 18, 2024 · 0 comments · Fixed by #6756
Labels
Bug Admin events aren't bugs

Comments

@TropicalFlak
Copy link
Contributor

TropicalFlak commented Jul 18, 2024

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit e04d971
#5829: '(EVENT) Cortical Borers' by realforest2001 at commit 9c9dfb5
#6400: 'Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now' by GrrrKitten at commit 2927345
#6737: 'Planted flag bugfix and warcry removal' by Zonespace27 at commit 43f33f8
#6308: 'Hostile Survivor Rework' by Steelpoint at commit 423ba81
#6742: 'Scout Cloak fix' by kiVts at commit 8e33dcd
#6745: 'Sound range ' by kiVts at commit 81428cd

Round ID

No response

Description of the bug

The moment you hit play/pause on a Walkman with a tape inside it will press both pause and play the current song at the same time. Can be done with any Walkman, tape, and song.

Not sure what causes this.

What's the difference with what should have happened?

It should either pause or play the music, depending on if it is playing or not.

How do we reproduce this bug?

  1. Get a Walkman
  2. Put in Ear Slot/Hands
  3. Insert Tape
  4. Press play/pause button.

Issue Bingo

@TropicalFlak TropicalFlak added the Bug Admin events aren't bugs label Jul 18, 2024
@TropicalFlak TropicalFlak changed the title Walkman buttons both toggle at once Walkman play/pause buttons toggle both functions at once Jul 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 19, 2024
# About the pull request
Calling the parent of all actions
(#6442) caused a lot of bugs,
this fixes that.

Closes #6755
Closes #6753
Closes #6732 
Closes #6742

# Explain why it's good for the game

Bugs are bad

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Tested on practically every object that has a use-in-hand functionality
with an action button.

</details>


# Changelog
:cl:
fix: Fixed a large amount of objects activating erroneous functionality
(like an armor light) when using action buttons tied to that object.
/:cl:

Co-authored-by: John Doe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant