CAS not detecting weapons

[cm13-issue-bot]

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit f69b5c5dcd
#6071: '[V] Sorokyne Strata: Expanded Small corridors, removed 3000 unused tiles, allow LAZ for CAS inside most structures, Xenos can now weed everything except LZ's and surrounding of LZ's.' by Venuska1117 at commit 9d5e6d4658
#6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit e947b927db
#6821: 'Shrapnel smooth movement' by Doubleumc at commit f8fca5f27e
#6783: 'New "Bulky" computers, small bug fixes also related to computers, addition of altitude controller to the CIC' by LC4492 at commit 71f595f697
#6712: 'Use DVIEW' by Doubleumc at commit f4b53dd614
#6692: 'Use RANGE_TURFS' by Doubleumc at commit 834383bfa0
#6682: 'Hugged changes' by zzzmike at commit 901f664a71
#6671: 'Successful AA interceptions now destroy the hijacked shuttle and end the round' by blackdragonTOW at commit 2a5bbd200b
#6652: 'autoclimbable handrails on harm intent' by cuberound at commit 7952d21d5d
#6860: 'Mentor New Player Markers' by realforest2001 at commit 6dacc271a5

Round ID

23346

Description of the bug

CAS menu does not detect installed weapons.

What's the difference with what should have happened?

CAS should detect installed weapons.

How do we reproduce this bug?

Install weapons
See they don't appear in fancy CAS TGUI.

Attached logs

[2024-08-03 07:04:06.401] runtime error: Cannot read null.attach_id
 - proc name: get sanitised equipment (/obj/structure/machinery/computer/dropship_weapons/proc/get_sanitised_equipment)
 -   source file: code/game/machinery/computer/dropship_weapons.dm,597
 -   usr: Daniel \'Driver\' Jimenez (/mob/living/carbon/human)
 -   src: the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2)
 -   usr.loc: the floor (92,58,3) (/turf/open/shuttle/dropship/medium_grey_single_wide_up_to_down)
 -   src.loc: the floor (92,59,3) (/turf/open/shuttle/dropship/medium_grey_single_wide_up_to_down)
 -   call stack:
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): get sanitised equipment(Daniel \'Driver\' Jimenez (/mob/living/carbon/human), Normandy (/obj/docking_port/mobile/marine_dropship/normandy))
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui data(Daniel \'Driver\' Jimenez (/mob/living/carbon/human))
 - /datum/tgui (/datum/tgui): get payload(null, 1, 1)
 - /datum/tgui (/datum/tgui): open()
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): tgui interact(Daniel \'Driver\' Jimenez (/mob/living/carbon/human), /datum/tgui (/datum/tgui))
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui interact(Daniel \'Driver\' Jimenez (/mob/living/carbon/human), "main", null, 0)
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): attack hand(Daniel \'Driver\' Jimenez (/mob/living/carbon/human), /list (/list))
 - Daniel \'Driver\' Jimenez (/mob/living/carbon/human): UnarmedAttack(the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), 1, /list (/list))
 - Daniel \'Driver\' Jimenez (/mob/living/carbon/human): click adjacent(the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), null, /list (/list))
 - Daniel \'Driver\' Jimenez (/mob/living/carbon/human): do click(the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), the floor (92,59,3) (/turf/open/shuttle/dropship/medium_grey_single_wide_up_to_down), "icon-x=20;icon-y=17;left=1;but...")
 - Rem1 (/client): Click(the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), the floor (92,59,3) (/turf/open/shuttle/dropship/medium_grey_single_wide_up_to_down), "mapwindow.map", "icon-x=20;icon-y=17;left=1;but...")
 - 
[2024-08-03 07:04:52.475] runtime error: Cannot read null.attach_id
 - proc name: ui data (/datum/cas_fire_mission_record/ui_data)
 -   source file: code/modules/dropships/cas/fire_mission_record.dm,10
 -   usr: Daniel \'Driver\' Jimenez (/mob/living/carbon/human)
 -   src: /datum/cas_fire_mission_record (/datum/cas_fire_mission_record)
 -   usr.loc: the floor (111,56,4) (/turf/open/shuttle/dropship/medium_grey_single_wide_up_to_down)
 -   call stack:
 - /datum/cas_fire_mission_record (/datum/cas_fire_mission_record): ui data(Daniel \'Driver\' Jimenez (/mob/living/carbon/human))
 - BIG GUN POWER!! (/datum/cas_fire_mission): ui data(Daniel \'Driver\' Jimenez (/mob/living/carbon/human))
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): get firemission data(Daniel \'Driver\' Jimenez (/mob/living/carbon/human))
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): ui data(Daniel \'Driver\' Jimenez (/mob/living/carbon/human))
 - /datum/tgui (/datum/tgui): get payload(null, 1, null)
 - /datum/tgui (/datum/tgui): send update(null, null)
 - tgui (/datum/controller/subsystem/tgui): try update ui(Daniel \'Driver\' Jimenez (/mob/living/carbon/human), the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2), /datum/tgui (/datum/tgui))
 - the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2): tgui interact(Daniel \'Driver\' Jimenez (/mob/living/carbon/human), /datum/tgui (/datum/tgui))
 - /datum/tgui (/datum/tgui): process(0.9, 1)
 - tgui (/datum/controller/subsystem/tgui): update uis(the \'Normandy\' weapons contr... (/obj/structure/machinery/computer/dropship_weapons/dropship2))
 - /datum/tgui (/datum/tgui): on act message("firemission-create", /list (/list), /datum/ui_state/not_incapacita... (/datum/ui_state/not_incapacitated_and_adjacent_strict_state))
 - /datum/tgui (/datum/tgui): on message("act/firemission-create", /list (/list), /list (/list))
 - /datum/tgui_window (/datum/tgui_window): on message("act/firemission-create", /list (/list), /list (/list))
 - tgui Topic(/list (/list))
 - Rem1 (/client): Topic("type=act%2Ffiremission-create&...", /list (/list), null)

Additional details

• Author: Rem1
• Admin: SmellyHippie
• Note: Somehow one of the rocket pods he installed entered null space, and couldn't be deleted. I had to null which in turn allowed another to be installed, then apparently the firemissons/direct fire stopped working completely.