Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foxrot specialist tech gives two specialists if no one rolls the beacon in freed mobs #7053

Closed
3 tasks done
kiVts opened this issue Aug 28, 2024 · 1 comment · Fixed by #7057
Closed
3 tasks done

Foxrot specialist tech gives two specialists if no one rolls the beacon in freed mobs #7053

kiVts opened this issue Aug 28, 2024 · 1 comment · Fixed by #7057
Labels
Bug Admin events aren't bugs

Comments

@kiVts
Copy link
Contributor

kiVts commented Aug 28, 2024

Testmerges

#6334 #6071 # 6824 #6820 #6808 #6977 #7025 #6039

Round ID

irrelevant

Description of the bug

If no one rolls the foxrot specialist, it gives two in the freed mobs

What's the difference with what should have happened?

One spec in freed mobs

What it actually is
image

How do we reproduce this bug?

1.Buy spec tech
2.have no one roll it
3.You now have two specs in the free mobs tab

Issue Bingo
@kiVts kiVts added the Bug Admin events aren't bugs label Aug 28, 2024
@kiVts
Copy link
Contributor Author

kiVts commented Aug 28, 2024

image

@github-staff github-staff deleted a comment from wuliaodexiaoluo Aug 28, 2024
@kiVts kiVts mentioned this issue Aug 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
@kiVts @harryob
Create_member no longer gets called twice (#7057)
b328b5e 
# About the pull request

mob_max is inclusive, and we start at zero.
# Explain why it's good for the game
 resolves #7053 

![image](https://github.com/user-attachments/assets/1d732615-e305-4b74-8d9f-68232abaead0)

It was kinda sad....
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: ERT no longer gets one extra free member in freed mobs if the
beacon wasnt completely taken
/:cl:

---------

Co-authored-by: harryob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create_member no longer gets called twice kiVts/cmss13
3 participants
@kiVts and others