-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
round traits framework + a few placeholders #2876
Conversation
Co-authored-by: carlarctg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemingly non-functional during tests on live.
The round traits modification menu may need to be a bit clearer on how it functions.
The flu round trait in particular was nonfunctional. Second round tests of mixed up squads did not seem to apply trait.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
show_in_human_report = TRUE | ||
human_report_message = "A small bonus has been deposited in the accounts of our personnel by The Company. Seemingly, they want everyone to co-operate with them on this operation." | ||
trait_to_give = TRAIT_ROUND_ECONOMIC_BOOM | ||
blacklist = list(/datum/round_trait/economic_boom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be slump
@@ -15,6 +15,32 @@ | |||
return GLOB.not_incapacitated_and_adjacent_strict_state | |||
|
|||
/obj/structure/machinery/cm_vending/sorted/cargo_guns/squad_prep/populate_product_list(scale) | |||
if(HAS_TRAIT(SSround, TRAIT_ROUND_STANDARD_ISSUE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
this allows for us to have randomised traits that will impact a whole round for a bit of variety. wouldn't that be nice?
🆑
add: added the framework for random traits impacting the whole round
add: added a number of traits, including flu season, faulty piping, book balancing, illicit dealings, faulty cryogenics, economic boom/slump, temperature change and mismatched squads
/:cl:
these should (if i've done the weighting right) not appear enough to be annoying
also
important
i would like to add more, especially for xenos and i'll be going through some ideas i curated prior to merge