-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosive barricade upgrade buff #3584
Explosive barricade upgrade buff #3584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops what did I do
Added 50% protection against fire as well. Flame destroys cades very quickly, so this is another niche anti-FF use for the upgrade. Thanks to superwelder for the suggestion. |
If numbers are too busted, I can change them upon request. But personally I think this is fine for such a niche thing. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else about this code wise looks fine.
About the pull request
Explosive barricade upgrade is renamed to composite upgrade, explosion damage taken is now modified by 0.5 (was 0.75), added 0.5 anti-projectile modifier (brute barricade upgrade basically has 0.75). Latest only applies to brute projectiles, so acid damage stays the same. Also added 0.5 anti-fire modifier (acid barricade upgrade basically has 0.75 as well).
Explain why it's good for the game
The explosive upgrade is almost never used because it is useless. This is a very weak insurance in case of a very bad situation, like an explosion inside the cades. Now it will be more like a dedicated anti-FF upgrade, so smartgunners or flamethrowers, for example, won't be grinding down cades so fast. Xenos won't be affected much because the only brute projectile they have is bone shards and those are not used much against cades.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 ihatethisengine
balance: explosive barricade upgrade provides better protection against explosions (25% to 50%)
balance: explosive barricade upgrade provides strong protection against brute-based projectiles (50%)
balance: explosive barricade upgrade provides strong protection against fire (50%)
/:cl: