Fix for dummy rotation in character setup. #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jun 23, 2023
cm13-github
added a commit
that referenced
this pull request
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Followup to #3516. That PR changed the general click behaviour from
if (click(A, mods) | A.clicked(src, mods, location, params))to use||instead. And in Byond, that means quick resolution: if left side is true, then right side is not evaluated - thus not executed - at all.I am not sure what exactly was that meant to address (or whether it was intentional at all, for that matter),but as it happens,/mob/new_player/click()is set to always simply return true while all the code for those arrows is in theirclicked(). Solution is obvious then.P.S. On second thought, reading the PR does explain the PR. But quick resolution is not exactly intuitive, and even though it is probably highly unlikely to ever change, there is probably no need to rely on it so implicitly. While I have the file open anyway, might as well make returning after the left half alone explicit.
Explain why it's good for the game
Is fix.
Changelog
🆑
fix: Preview dummy in character setup once again can be rotated.
/:cl: