Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[s] Require affirmative input from the admin to run sdql2 verbs #3710

Merged
merged 1 commit into from
Jun 25, 2023
Merged

[s] Require affirmative input from the admin to run sdql2 verbs #3710

merged 1 commit into from
Jun 25, 2023

Conversation

Zonespace27
Copy link
Contributor

"Powerful or dangerous admin verbs should have some prompt or forced runtime input to lower the attack surface once somebody finds a href exploit since topics can trigger commands and verbs."

Thanks MSO

tgstation/tgstation#76276

fira
fira approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a bit backwards to me (why have it a verb at all?) but i guess this works

@harryob harryob added this pull request to the merge queue Jun 25, 2023
Merged via the queue into cmss13-devs:master with commit 2fe028d Jun 25, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fira fira fira approved these changes

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zonespace27 @fira @harryob