Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lurker no longer decloaks if they pounce onto a dead guy. #3724

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented Jun 25, 2023

About the pull request

Doesn't make sense to lose your cloak for pouncing at a dead guy.

They'll still decloak if it's a living guy hiding under a dead guy.

(This only happens if your pounce ends on a tile where there's a dead guy)

Explain why it's good for the game

Inconsistent at best. Bad

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Lurkers no longer lose their pounce if they happen to end their pounce on a tile with a dead human
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 25, 2023
@morrowwolf morrowwolf marked this pull request as draft June 27, 2023 08:17
@TheGamerdk TheGamerdk closed this Jun 27, 2023
@TheGamerdk TheGamerdk reopened this Jun 27, 2023
@TheGamerdk TheGamerdk marked this pull request as ready for review June 27, 2023 21:05
@TheGamerdk TheGamerdk marked this pull request as draft June 28, 2023 05:41
@ihatethisengine
Copy link
Contributor

Discord broke indentations

@TheGamerdk
Copy link
Contributor Author

Discord broke indentations

I saw

@TheGamerdk TheGamerdk marked this pull request as ready for review June 28, 2023 17:49
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I even test merged with the new weeded bodies to make sure the interaction was the same.

@Drulikar Drulikar added this pull request to the merge queue Jun 29, 2023
Merged via the queue into cmss13-devs:master with commit 5eba560 Jun 29, 2023
28 checks passed
github-actions bot added a commit that referenced this pull request Jun 29, 2023
cm13-github added a commit that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants