Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synth armour sprite change #3728

Merged
merged 9 commits into from
Jul 5, 2023

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Jun 26, 2023

About the pull request

The sprite for the Synthetic utility vest/armour is now slimmer.

Explain why it's good for the game

Fat synthetics not required for service.

Testing Photographs and Procedure

Screenshots & Videos

Screenshot 2023-06-26 17 37 24

Left is new sprite. Right is current sprite.

Changelog

🆑
imageadd: Synth utility vest is now slimmer in appearance
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -7. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Jun 26, 2023
@Steelpoint Steelpoint changed the title Slims Synth Armour Synth armour sprite and speed change Jun 28, 2023
@Steelpoint
Copy link
Contributor Author

As per a request from the Synthetic Council I have made an addition to this PR that reduces the speed penalty of the utility vest to arpoximantly a 20% penalty now. OP has been updated.

@morrowwolf morrowwolf added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 28, 2023
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

VL_syn has too much cut off of the east/west sprites compared to the other variants.
everything else is fine

@Steelpoint
Copy link
Contributor Author

Fixed the issue.

@sleepynecrons
Copy link
Contributor

sleepynecrons commented Jul 2, 2023

Fixed the issue.

west is fixed east still needs fixing
image

@Steelpoint
Copy link
Contributor Author

Think its fixed again

Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites approved

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Jul 3, 2023
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the slowdown change its own PR.

@morrowwolf morrowwolf marked this pull request as draft July 5, 2023 06:25
@Steelpoint Steelpoint changed the title Synth armour sprite and speed change Synth armour sprite change Jul 5, 2023
@Steelpoint Steelpoint marked this pull request as ready for review July 5, 2023 08:09
@Steelpoint
Copy link
Contributor Author

Done

@morrowwolf morrowwolf removed the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 5, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Jul 5, 2023
Merged via the queue into cmss13-devs:master with commit 89140e6 Jul 5, 2023
28 checks passed
github-actions bot added a commit that referenced this pull request Jul 5, 2023
cm13-github added a commit that referenced this pull request Jul 5, 2023
@Steelpoint Steelpoint deleted the SpriteChangeSynth branch July 5, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants