Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimap removeimage proc not checking z level correctly #3752

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix minimap removeimage proc not checking z level correctly #3752

merged 2 commits into from
Jun 29, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jun 28, 2023 •
edited by github-actions bot
Loading

About the pull request

This PR fixes an issue where the removeimage proc in the minimap subsystem didn't get the turf of the target to correctly test what Z level they were added to such as being deleted in a cryopod. (Entering say a cryopod is not considered a onTransitZ trigger despite the z value changing)

Explain why it's good for the game

This PR should fix runtimes such as:

[2023-06-28 07:08:53.119] runtime error: /list {len = 5}l"istress Signal"Êß@'
 - proc name: removeimage (/datum/controller/subsystem/minimaps/proc/removeimage)
 -   source file: minimap.dm,266
 -   usr: null
 -   src: Minimaps (/datum/controller/subsystem/minimaps)
 -   call stack:
 - Minimaps (/datum/controller/subsystem/minimaps): removeimage(, Leroy Luna (/mob/living/carbon/human))
 - /datum/callback (/datum/callback): Invoke()
 - Minimaps (/datum/controller/subsystem/minimaps): remove marker(Leroy Luna (/mob/living/carbon/human), null, null)
 - the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom): dropped(Leroy Luna (/mob/living/carbon/human))
 - Leroy Luna (/mob/living/carbon/human): u equip(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null)
 - Leroy Luna (/mob/living/carbon/human): u equip(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null)
 - Leroy Luna (/mob/living/carbon/human): u equip(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null)
 - Leroy Luna (/mob/living/carbon/human): drop inv item to loc(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null)
 - the hypersleep chamber (/obj/structure/machinery/cryopod/right): despawn occupant()
 - the hypersleep chamber (/obj/structure/machinery/cryopod/right): process()
 - Machinery (/datum/controller/subsystem/machinery): fire(0)
 - Machinery (/datum/controller/subsystem/machinery): ignite(0)
 - Master (/datum/controller/master): RunQueue()
 - Master (/datum/controller/master): Loop(2)
 - Master (/datum/controller/master): StartProcessing(0)

Testing Photographs and Procedure

Screenshots & Videos

cryo

Changelog

🆑 Drathek
fix: Fix runtimes with minimap subsystem not handling targets inside of objects during removal
/:cl:

@Drulikar Drulikar requested a review from harryob June 28, 2023 08:38
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 28, 2023
@harryob harryob added this pull request to the merge queue Jun 29, 2023
Merged via the queue into cmss13-devs:master with commit 5700c6c Jun 29, 2023
30 checks passed
cm13-github added a commit that referenced this pull request Jun 29, 2023
@cm13-github
Automatic changelog for PR #3752 [ci skip]
156fa39
github-actions bot added a commit that referenced this pull request Jun 29, 2023
@github-actions
Updating GBP balances for #3752
a61158c
@Drulikar Drulikar deleted the Fix_Minimap_Remove_Image_Z branch June 29, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Fix Fix one bug, make ten more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drulikar @harryob