Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readds old MP uniform, armor and headgear. Adds MP lore descriptions. Tweaks MP locker loadouts. #3758

Closed
wants to merge 2 commits into from

Conversation

silencer-pl
Copy link
Contributor

@silencer-pl silencer-pl commented Jun 28, 2023

About the pull request

Based on implicit permission by the server host and explicit permission by the server vice host, this PR re-adds the previous MP gear sets - the uniforms, armors and headgear. All of these are available as optional picks from respective gear vendors. In the future I do intend to make it a character picker option so you can spawn in the provost issue gear, but that can be added via a separate PR later.

In order to explain the place of both sets of gear in the game world the PR also adds fairly extensive lore_descs to all uniform, armor, headgear sets added and their counterparts. The JAS also got a lore_desc that further explains the reason for these sets to exist at the same time and be available as an option to MP players.

Further, since I was changing those already, this MR readds black and brown webbing as gear options into the MP vendor, as well as readds a full MP tool belt as one of the basics. Black webbing in particular is extra useful to MP players due to its storage type and there does not seem to be a reason not to have them available, especially since the CMP locker still has them all available. The order of things in all lockers has been somewhat tweaked mostly to maintain parity in terms of order with each other.

Some of the descriptions have also been tweaked, I dumped the kevlar etc mentions from the uniforms and the legacy ss13 description fluff and instead tried to give them more character. All uniforms were still referred to as "jumpsuits" in their item names. They still do in their icon names, but I'll save fixing that for later.

Lastly the new warden uniform was missing an item icon, I made one based off its item sprite and the regular mp item icon.

Oh and I also dumped one more funny dumb reference from the peaked cap description that I missed last time.

Explain why it's good for the game

In-world rich lore entries that allow players to orient themselves in the game world, provide potential plot hooks in their RP and give them more information about who their character could be and what training their received are fairly critical element of any decent RP setting, regardless what weight, flavor, color, or dance orientation of RP server we are.

Since the Provost Office is a CM creation, the lore is based on a good 800+ hours of MP gameplay and untold hours of interacting with MP players of all caliber and approach as staff both IC and OOC. The lore very much embraces an already existing perception and division in terms of approach and being able to express that in IC terms and back it up with IC information.

Having more cosmetic options, especially for roles that are heavily RP based and that can themselves be catalysts for RP is a net gain for both those roles and the other players they interact with.

Fixed item icons and the right gear available from vendors are bug fixes and bugs are bad.

Order of items is a QOL fix, uh... That's a good thing :P

Testing Photographs and Procedure

Screenshots & Videos

The many faces of Cassandra Reed.
image

Changelog

🆑silencer_pl
add: All MP roles can now pick Provost Issue uniforms, armor and headgear from their gear lockers.
add: The JAS, all MP uniforms, armor and some headgear now have lore descriptions.
add: Re-added colored webbing and full MP toolbelts to MP and Warden gear lockers.
fix: All MP uniforms are now actually called uniforms.
fix: The Warden uniform now has the right item icon.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Fix Fix one bug, make ten more labels Jun 28, 2023
@morrowwolf
Copy link
Member

Thank you but we are not interested in going in this direction at this time.

@morrowwolf morrowwolf closed this Jun 28, 2023
@@ -2,7 +2,8 @@

/obj/structure/machinery/computer/sentencing
name = "\improper Jurisdictional Automated System"
desc = "A powerful machine produced by Weyland-Yutani to streamline all punishment of prisoners. The best grade policing gear seen on this side of the galaxy."
desc = "A powerful machine develiped jointly with Weyland-Yutani to make sure every convict gets exactly the brig timer they deserver accroding to regulations. A living symbol of the somewhat strainder realationship of the Provost Office and the rest of the USCMC."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc = "A powerful machine develiped jointly with Weyland-Yutani to make sure every convict gets exactly the brig timer they deserver accroding to regulations. A living symbol of the somewhat strainder realationship of the Provost Office and the rest of the USCMC."
desc = "A powerful machine developed with Weyland-Yutani to ensure every convict gets exactly the brig timer they deserve according to regulations. A living symbol of the somewhat strained relationship between the Provost Office and the rest of the USCMC."

@@ -2,7 +2,8 @@

/obj/structure/machinery/computer/sentencing
name = "\improper Jurisdictional Automated System"
desc = "A powerful machine produced by Weyland-Yutani to streamline all punishment of prisoners. The best grade policing gear seen on this side of the galaxy."
desc = "A powerful machine develiped jointly with Weyland-Yutani to make sure every convict gets exactly the brig timer they deserver accroding to regulations. A living symbol of the somewhat strainder realationship of the Provost Office and the rest of the USCMC."
desc_lore = "The Jurisdictional Automated System and procedures surrounding it were conceived as a result of a through statistical analysis of USCMC arrest records and Marine Law violations that concluded that three out of four convictions end up with a misapplied timer. The fact that the Provost Office was unusually cooperative should probably have been a hint that something was off, and as the JAS entered service accuracy of brig timers increased to around 98% in cases where charges where applied correctly. Unfortunately it also became very clear that this increased, not decreased the average time a Marine spends in the brig by almost 50 percent. It was later revealed that the Office itself suspected that was the case from their own numbers but opted not to share that information, themselves not being exactly pleased with the leniency in brig timers and decided to use this initiative to their own ends. This caused a major rift between USCMC leadership and key figures in the Provost Office that ultimately got settled by the UAAC who established the split training program which despite its overall failure to majorly temper the specific behaviors of MPs on USCMC assignments did shift overall perspective to at least consider negotiation and deescalation an equally valid approach to direct confrontation."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc_lore = "The Jurisdictional Automated System and procedures surrounding it were conceived as a result of a through statistical analysis of USCMC arrest records and Marine Law violations that concluded that three out of four convictions end up with a misapplied timer. The fact that the Provost Office was unusually cooperative should probably have been a hint that something was off, and as the JAS entered service accuracy of brig timers increased to around 98% in cases where charges where applied correctly. Unfortunately it also became very clear that this increased, not decreased the average time a Marine spends in the brig by almost 50 percent. It was later revealed that the Office itself suspected that was the case from their own numbers but opted not to share that information, themselves not being exactly pleased with the leniency in brig timers and decided to use this initiative to their own ends. This caused a major rift between USCMC leadership and key figures in the Provost Office that ultimately got settled by the UAAC who established the split training program which despite its overall failure to majorly temper the specific behaviors of MPs on USCMC assignments did shift overall perspective to at least consider negotiation and deescalation an equally valid approach to direct confrontation."
desc_lore = "The Jurisdictional Automated System and procedures surrounding it were conceived as a result of a thorough statistical analysis of USCMC arrest records and Marine Law violations which concluded; three out of four convictions end up with a misapplied timer. The Provost Office being unusually cooperative should probably have been a hint something was off, and as the JAS entered service accuracy of brig timers increased to around 98% in cases where charges were applied correctly. Unfortunately it also became very clear that this increased, not decreased the average time a Marine spends in the brig by almost 50 percent. It was later revealed that the Office itself suspected this would be the case based on their own statistics but opted to bury that information, not being pleased with the leniency in brig timers, using the initiative to their own ends. This caused a major rift between USCMC leadership and key figures in the Provost Office that ultimately got settled by the UAAC who established the split training program which despite its overall failure to temper the specific behaviors of MPs on USCMC assignments did shift overall perspective to at least consider negotiation and de-escalation an equally valid approach to direct confrontation."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time at the moment but you need to go over the rest of these with a fine-toothed comb for spelling or grammar errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the general format of these is acceptable, I will indeed give these multiple look overs if need to until they are as polished as they need to. Anyway, will definitely give all of the text another through look because I'm sure I missed things.

@silencer-pl silencer-pl deleted the mploredripbuff branch August 19, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants