-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
People with lisp now lisp on radio #3760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm aware these changes make stuff inconsistent, but all of these cases (handled and speech_problem_flag should be using the TRUE/FALSE defines instead of 1/0 (they're the same thing but it's neater)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
About the pull request
The lisp trait did not affect a flag for speech, making it so lisping does not occur over radio, this should make it so what they say is transmitted properly.
Explain why it's good for the game
Fixes an oversight and allows for lisp speech to be handled by the handle_speech_problems method. Also realism or something
Testing Photographs and Procedure
Screenshots & Videos
Poor marine trying to alert command
Changelog
🆑
fix: lisps now occur over radio as well
refactor: Relevant variables relating to speech problems now use true and false instead of 1 and 0
/:cl: