Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People with lisp now lisp on radio #3760

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jun 28, 2023

About the pull request

The lisp trait did not affect a flag for speech, making it so lisping does not occur over radio, this should make it so what they say is transmitted properly.

Explain why it's good for the game

Fixes an oversight and allows for lisp speech to be handled by the handle_speech_problems method. Also realism or something

Testing Photographs and Procedure

Screenshots & Videos

image
Poor marine trying to alert command

Changelog

🆑
fix: lisps now occur over radio as well
refactor: Relevant variables relating to speech problems now use true and false instead of 1 and 0
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 28, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm aware these changes make stuff inconsistent, but all of these cases (handled and speech_problem_flag should be using the TRUE/FALSE defines instead of 1/0 (they're the same thing but it's neater)

code/modules/character_traits/biology_traits.dm Outdated Show resolved Hide resolved
code/modules/character_traits/biology_traits.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/say.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 30, 2023 09:39
@Ben10083 Ben10083 marked this pull request as ready for review June 30, 2023 15:09
@Ben10083 Ben10083 requested review from harryob June 30, 2023 15:09
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@harryob harryob added this pull request to the merge queue Jun 30, 2023
Merged via the queue into cmss13-devs:master with commit db2384b Jun 30, 2023
30 checks passed
github-actions bot added a commit that referenced this pull request Jun 30, 2023
cm13-github added a commit that referenced this pull request Jun 30, 2023
@Ben10083 Ben10083 deleted the Lisp_Radio branch July 1, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants