Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Pouches Tweaks & Fixes #3764

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

ghostsheet
Copy link
Contributor

@ghostsheet ghostsheet commented Jun 29, 2023

About the pull request

large general pouch has stricter restriction against internal boxes.

Remove the one medium item restriction for large general pouch, makes it more competitive with other pouches

Added Large general pouch to REQ at the same rarity as Large Shotgun pouch, why wasn't it there before? we can reduce further if it's necessary

Reshuffled Req Pouch order, Grouped pouches by type, medical > engineering> Misc > Ammo, RIP muscle memory

Remove some useless code

Explain why it's good for the game

more gameplay option good, QOL good, useless code bad

Changelog

🆑 ghostsheet
add: Large General Pouch has stricter restriction against internal boxes.
add: Large General Pouch no longer restricted to 1 medium item.
add: Large General Pouch added to REQ.
add: Shuffled REQ pouch order into Meds, Engi, Misc, Ammo.
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -4. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Fix Fix one bug, make ten more Feature Feature coder badge labels Jun 29, 2023
@ghostsheet ghostsheet force-pushed the General-pouch-Tweaks-&-Fixes branch from 74b6289 to 7142a10 Compare June 29, 2023 08:37
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restrictions against internal storages fine.
Restriction removal of one medium item fine.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 11, 2023
@ghostsheet ghostsheet force-pushed the General-pouch-Tweaks-&-Fixes branch from 7142a10 to 9920106 Compare July 16, 2023 04:43
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 18, 2023
@ghostsheet ghostsheet force-pushed the General-pouch-Tweaks-&-Fixes branch from 9920106 to 4bd7780 Compare July 19, 2023 05:51
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 19, 2023
@Drulikar
Copy link
Contributor

ghostsheet force-pushed the General-pouch-Tweaks-&-Fixes branch 💢

@Drulikar Drulikar removed the Fix Fix one bug, make ten more label Jul 19, 2023
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 20, 2023
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 31bbe21 Jul 24, 2023
27 checks passed
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-6). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Jul 24, 2023
cm13-github added a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants