Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes evac pod crash chance from a define to a var #3790

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

BeagleGaming1
Copy link
Contributor

About the pull request

Changes the crash from define to a variable to allow it to be changed
Adds a proc to force crash the shuttle, either if docked or in space

Explain why it's good for the game

This allows the crash chance to be changed, instead of just being static

Changelog

🆑
code: evacuation pod crash chance changed to a var
code: proc added to force evacuation pods to crash
/:cl:

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 3, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 3, 2023
@github-actions github-actions bot added the Code Improvement Make the code longer label Jul 3, 2023
@BeagleGaming1 BeagleGaming1 changed the title Changes crash from a define to a var on the shuttle Changes evac pod crash chance from a define to a var Jul 3, 2023
Copy link
Contributor

@mullenpaul mullenpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that this is to allow for admins to modify things on the fly? One future change I would like to see is a chance of a dropship hijack to alter this crash landing chance - outside the scope of this work but food for thought.

@BeagleGaming1
Copy link
Contributor Author

BeagleGaming1 commented Jul 3, 2023

I'm guessing that this is to allow for admins to modify things on the fly? One future change I would like to see is a chance of a dropship hijack to alter this crash landing chance - outside the scope of this work but food for thought.

Yeah, mostly this, but also morrow plans to add ways to change pod crash chances in a round, and it would probably be easier to change crash chance if its a variable instead of a define

@morrowwolf morrowwolf added this pull request to the merge queue Jul 5, 2023
Merged via the queue into cmss13-devs:master with commit 1eed982 Jul 5, 2023
27 checks passed
github-actions bot added a commit that referenced this pull request Jul 5, 2023
cm13-github added a commit that referenced this pull request Jul 5, 2023
@BeagleGaming1 BeagleGaming1 deleted the crash-chance branch September 15, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants