Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laser engraves and rewrites fountain pen flavor + adds detailed lore #3796

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

Hopekz
Copy link
Contributor

@Hopekz Hopekz commented Jul 4, 2023

I've received a lot of positive feedback for this pen so since it is semi-important now I went ahead and took the time to get out some extended lore for this item and re-did the original description flavor text now that I decided it was made by ARMAT.

To-do maybe :

  • Make the pen resistant to acid to comply with the new lore. (not 100% sure yet but would be funny if the only thing left over from a command member dying is their pen)
  • This PR or next but I want to add a laser engraving with the owner's name directly on the pen.
  • Probably future PR but now that engravings are here I want to make it so that laser engravings don't happen unless you are command staff

dreamseeker_w51xOzqhf0
dreamseeker_rfZMGoUh14

Update

There is now a laser engraving on the owner of the pen. Here is how that looks in-game:

dreamseeker_vUqjoQxujG

🆑 Hopek
add: Changed the description flavortext of the fountain pen to match the new lore. There is now a laser engraving of the owner on the pen itself.
add: Added a detailed lore description for the fountain pen.
/:cl:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

You currently have a negative Fix/Feature pull request delta of -21. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added the Feature Feature coder badge label Jul 4, 2023
@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 4, 2023

You currently have a negative Fix/Feature pull request delta of -21. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

🖕

@Hopekz Hopekz changed the title Rewrites flavor and adds detailed lore to fountain pen laser engraves and rewrites flavor fountain pen + adds detailed lore Jul 5, 2023
@Hopekz Hopekz changed the title laser engraves and rewrites flavor fountain pen + adds detailed lore laser engraves and rewrites fountain pen flavor + adds detailed lore Jul 5, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 13, 2023
@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 13, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

🖕

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 14, 2023
@harryob harryob marked this pull request as draft July 14, 2023 12:06
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 22, 2023
@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 22, 2023

Might reopen this in the future when CM dev picks back up closer to how it was when I started. (turnaround back to 3-4 days)

Personally for me it is a bit mentally exhausting at the moment to be open to modify something for a month so assuming I haven't moved on to another project I'll reopen this when I come back to CM dev.

@Hopekz Hopekz closed this Jul 22, 2023
@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 24, 2023

On second review this one is probably fine too

@Hopekz Hopekz reopened this Jul 24, 2023
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 25, 2023
@Hopekz Hopekz marked this pull request as ready for review July 25, 2023 05:30
@harryob harryob enabled auto-merge July 25, 2023 05:55
@harryob harryob added this pull request to the merge queue Jul 25, 2023
Merged via the queue into cmss13-devs:master with commit 4954038 Jul 25, 2023
25 checks passed
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-26). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

cm13-github added a commit that referenced this pull request Jul 25, 2023
github-actions bot added a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants