-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working Joe Death Sound and Death Message (It is so Joever) #3798
Conversation
This should be good enough to put up for review, other sounds for death occur at about 5% chance |
code/modules/mob/living/carbon/human/species/working_joe/_species.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/human/species/working_joe/_species.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/human/species/working_joe/_species.dm
Outdated
Show resolved
Hide resolved
…ies.dm Co-authored-by: harryob <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
This PR gives Working joes a unique death sound and death message....upon death.
TODO:
Explain why it's good for the game
For the same reasons we added the initial Working Joe audible emotes, this will add more depth to the Joes and make them even more uncanny. (Also default death message makes no sense as Working Joe eyes are already dead and lifeless.)
Testing Photographs and Procedure
Screenshots & Videos
YouAlwaysKnew.mp4
Example of default death noise playing, what most will hear.
Changelog
🆑
add: Working Joes now have a unique death message. Credit to Quickload for the message.
soundadd: Working Joes now have a death rattle. Credit to Quickload for shifting through Alien Isolation audio files.
qol: Things that die with intent eyes now lose color in their eyes on death.
/:cl: