Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes extraneous messages in regards to wall nests #3807

Merged

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Jul 5, 2023

About the pull request

Mouse drop was not checking for if you were actually grabbing something before passing to the proc like in the other areas it is called which caused extraneous messages.

Also, mouse drop does not guarantee a mob being passed which was causing extraneous and confusing messages when dropping wall resin onto a wall while dragging something.

Explain why it's good for the game

Confusing and extraneous messages bad.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
fix: Fixed extraneous messages in regards to wall nests
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 5, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Jul 7, 2023
Merged via the queue into cmss13-devs:master with commit 45de3ce Jul 7, 2023
30 checks passed
github-actions bot added a commit that referenced this pull request Jul 7, 2023
cm13-github added a commit that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants